Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4204648ybi; Mon, 15 Jul 2019 05:31:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9UBHMTXdXZlRYziKrGTVKAhwafa/CdvwzMVzB+WLYqteJZFV/E9nenf66GqcCLS6h7zIa X-Received: by 2002:a17:902:e281:: with SMTP id cf1mr27180444plb.271.1563193903906; Mon, 15 Jul 2019 05:31:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563193903; cv=none; d=google.com; s=arc-20160816; b=Q3gVWVylpnDQk6TNM9voqRmhXFKv6lN7Fx/ZItI1DmhtGfEvbaNIajG5p/9+A5rPc1 8x3wIgTw/lszkLs0zpd6whftFosXlcvaS9z9gGckfQAEWEp6BBu3oLL2d9gUIMv52ZEW lj/riR2/lbwubzwzpuIQoRzuETgP7ziQS+GjYxgCMWAz7hKM0ToPsTNL3EdzpgPHyrRl io1WdZroksA3z2EfKYAP1UIecL0s/mAoK0PwmtMUN8HM/EZeDkLc9lsGPvKPMIZDU/39 ilCzov8bGiOWRCmmH/ksUlREOMpTzoWG9/4LnPk9gzLysAOPOBYBwV9YL/b+BRjrop+Y LpOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=GKwQl5sysfH8rwSSzi5740Al0ZaBVIYRkC3IIKTMZbU=; b=icnDUD9yHJFPBBz/w1Yxc6njCGsBn8aNA+aL4rlJJXQSf3sFkCDGExcifreNrZL4eH BZaSFOMOCMOMdUAAxAUaMls4ep33dAYQ2PA/DUtDurqb6Zmm478h1Rb6ErmUu65XsQF2 QZuPGLeChcAGl+PLTviXJ7hmq1/ec8mYWGFX2G51yAYp3NZ21Qc2wMU4FH2SgZ8r7jdp +a6ERIVLeXasTMb5vn2KKJ4ixR96HzzEnpRSg44cTHvWlxIhVHxIqRzIRcBDO//qFFdu T/GG+1USZQsojcwUV0dU0tQ37nG3IClqPRq9GGmn/9wA2WCuSoM1NWsFvw8Y9lDsmUjT mjqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 72si15614582plb.177.2019.07.15.05.31.24; Mon, 15 Jul 2019 05:31:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730080AbfGOM34 (ORCPT + 99 others); Mon, 15 Jul 2019 08:29:56 -0400 Received: from verein.lst.de ([213.95.11.211]:60271 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbfGOM34 (ORCPT ); Mon, 15 Jul 2019 08:29:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CCC8A68B05; Mon, 15 Jul 2019 14:29:53 +0200 (CEST) Date: Mon, 15 Jul 2019 14:29:53 +0200 From: Christoph Hellwig To: Maxim Levitsky Cc: Benjamin Herrenschmidt , Christoph Hellwig , Keith Busch , Jens Axboe , "linux-kernel@vger.kernel.org" , linux-nvme@lists.infradead.org, Paul Pawlowski Subject: Re: [PATCH] nvme: Add support for Apple 2018+ models Message-ID: <20190715122953.GB3937@lst.de> References: <71b009057582cd9c82cff2b45bc1af846408bcf7.camel@kernel.crashing.org> <20190715081041.GB31791@lst.de> <25c3813ab1c2943658d7e79756803801b14a34db.camel@kernel.crashing.org> <4caeb954b2fa91445e02bac7ac9610ca886b4dd8.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4caeb954b2fa91445e02bac7ac9610ca886b4dd8.camel@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 15, 2019 at 12:28:05PM +0300, Maxim Levitsky wrote: > > To be honest, the spec explicitly states that minimum submission queue entry size is 64 > and minimum completion entry size should be is 16 bytes for NVM command set: That doesn't keep Apple from implementing whatever they want and soldering that down on their MacBook mainboards unfortunately :(