Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4256723ybi; Mon, 15 Jul 2019 06:18:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzce7KsircN674ZDHhLgd5iRp7F1ezPfwL6RAYDmYZP3z1Zbll6cCVl8/Yz/F63hm7StZ9B X-Received: by 2002:a17:90a:24e4:: with SMTP id i91mr30484466pje.9.1563196717895; Mon, 15 Jul 2019 06:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563196717; cv=none; d=google.com; s=arc-20160816; b=ngrwMsPr8m6NRChsyLxlP/ObvnJClyeftgmu9LQeHQXbRhx+8yFrw/+T7f1h3VD+nC E2s1SaaRTh+eGTyFoA/dSzdAoiS+W1OElO55wWFO7hKT+mWyMSTd+xTMEWYvrM9M9QgN w/MvyUTuSWr6uYriQR0R/EM1lFAgswP01fGHtS/elacDr/rQQHn8LKt9TLuHi1RzwJh4 3ktaqw9F0YPOkvd8N7Ho5BuyqGFiwoT9Q5neafc47q70VTX9cJJUY6a5ai3CN4VJs2MU QvKCPBFGM40XrJTykV6cmcfNfgYmoHnIpaSQ+/wt57/sQhx5sxCcs7bN4db9kyjRIXqH /rqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wQfUksnx/a5DGMCKTjZFd/leuZwE4dxH+KwTxbEOG70=; b=KWRkGdQayW/EaYGoVHNfJssPw+nbpCGV7Rb3qEEbjnW7D1dtmit7dfJp4QSTDf7hem yUK16nkpu+Rm9REIZSeQ8Drp5yqLiCCbbJ0OgmbRHt3UVPh3qdXvSbcV5upkY+bdAwtB VvnsJkUvLoAbQigtStuAs8rLyn9O0LfV5KSePmFPf+2qyLB/bBleGTcfvZHYPyydYenx zT+a8aEqD6Shuvby5NEiiVGAyQf+IuVP6WJvXvhNNz/tDS3Swaqsp2QWLoDt+jmWzhc/ xadj1Q0RfHXiEaL2Vn8TZa5PQrNLQ/jaXK07aaGf5uxyepG1yvjsx3yHcvXlpkjZn5Yw HJTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci23si15037807pjb.106.2019.07.15.06.18.21; Mon, 15 Jul 2019 06:18:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730162AbfGONRh (ORCPT + 99 others); Mon, 15 Jul 2019 09:17:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:49938 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730012AbfGONRg (ORCPT ); Mon, 15 Jul 2019 09:17:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0CA51AF7E; Mon, 15 Jul 2019 13:17:34 +0000 (UTC) Date: Mon, 15 Jul 2019 15:17:32 +0200 From: Michal Hocko To: Yang Shi Cc: dvyukov@google.com, catalin.marinas@arm.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case Message-ID: <20190715131732.GX29483@dhcp22.suse.cz> References: <1562964544-59519-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562964544-59519-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 13-07-19 04:49:04, Yang Shi wrote: > When running ltp's oom test with kmemleak enabled, the below warning was > triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is > passed in: kmemleak is broken and this is a long term issue. I thought that Catalin had something to address this. While this patch only adds a comment and discourages future changes of the warning which is fine and probably something that we should do, kmemleak really should be fixed sooner than later. -- Michal Hocko SUSE Labs