Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4349925ybi; Mon, 15 Jul 2019 07:38:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqydwKDmdrjZqRZFbOSg10CGNMPVFsaxyrHNqWluR/rENZP+yhZXDY4obFZf1fruGH5atdJ3 X-Received: by 2002:a63:520f:: with SMTP id g15mr24040163pgb.28.1563201539110; Mon, 15 Jul 2019 07:38:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563201539; cv=none; d=google.com; s=arc-20160816; b=BTjONNRTtOVbzZrSK2bTILJ2ABZOkQfyEqq0K1fd0t6rX0hn79Zwfzb7bizw9SXLOX iBQiMQ4jHBR9xQEGhmAXtR0n6149a5Xo8xswS9ngueRzq6x6auniqC75+1Y9Ax7tbFBq K9hPkncEGsbPlHWnG8iqAQjDfrDsJ+k7Dw7PDWGXIUAa/fIL8/np5bVKb6hQS/HX++y9 G/JZ53FYw/T0crwMLWXTqxwHhgN2YWuqZfObPxulC4A+NS9L668f2Dn7qkZqsT6gaeU0 cxprnBanVQOWIMsjEYOx8QKO9c9YdetFEMfpFK6inCbA5LW/OXFzshzwtp/2EUXJC0fR dR4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z+lAujGo7GrSG40jkK2/203/pKxvTLE13nrgeKcOwgI=; b=QmBoyz0E6X1A+dACI3byhyrUQ+ykLg715XRy9eSwuvGtG1tfl4eQuPGA2Sv40YR7in CTGDgHYgcbMdun1UA25M6ybNVpgf6syHE5EVpkCgky11+vAxxhrZTY97eR7XkgxZd+fi 1kj1nfODempTBa/3wA61LqFY25PZFHHRI0pTX6aTst1Zvge8lhlKy9EwbH2VxMzvwXui SmbEWZYRa8poOSm+4ZDsNWRBP+H6qIzWT7PmsFAr8kB8IolS9JYgnA8Pfqiegao7Rv+u KT5Bvg7/GKh0gyJxhxAcEk6I8qAh4AzuZ342OKibosXrkxyaI6ItcwuUX3bJojYBPZOl mkBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AUubZl4E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si16801993pfk.246.2019.07.15.07.38.42; Mon, 15 Jul 2019 07:38:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=AUubZl4E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404703AbfGOOha (ORCPT + 99 others); Mon, 15 Jul 2019 10:37:30 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33642 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404569AbfGOOh1 (ORCPT ); Mon, 15 Jul 2019 10:37:27 -0400 Received: by mail-pl1-f196.google.com with SMTP id c14so8376607plo.0 for ; Mon, 15 Jul 2019 07:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z+lAujGo7GrSG40jkK2/203/pKxvTLE13nrgeKcOwgI=; b=AUubZl4ETLIsW/m5dgXLBulJXDHc0BCosX1eCwyxi+94m0Nn+UMJmqa85ypsCsZq1j xz0LM9usgNKyVFOetyi7Bh0t5cemvEnRKdil/TVdpWNJXsluRFLQGvr0RhdUuQJTVlAU AAiUQF4zYjdlsdkxFoX9G9U8IN3eAZ1c3LtuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z+lAujGo7GrSG40jkK2/203/pKxvTLE13nrgeKcOwgI=; b=gS57nL+hxGavK8xUefTeI06r2Z1f0djyDNcufj42lNM0tIwns6kFxmcO0j82JI/LTn 10s8aWaOM5tH8Gjv2RF5NL7+l2De/X7js3Lo28GPoJX5UwNmTjJhB+oG/A82GJ1y+W4r jw44teQ8C/cUbQbhRXis82g6bBm24ziQAfbKVMhqKJcx9RloUs69uf/LzX47kq9/4cGm brHSLXyC9569dIXXCvkYD5KxuVSfrh5+yEXjpMmiX2iuGIVvc/XdttXwyztSfUzt183F vI3kAdZDFY1qrfjil/7QV6sZ/hUwC9BZ/6a6hyTcTF3JWVxNBEn1SKI/gceqlra/eJuv Vovg== X-Gm-Message-State: APjAAAXKAs5+IYk9n7fHj7RfDGDN/vmzgE85wgZ0I8/SMKlcLF98J2lw Jkd26MCAaFQGVEp0+PW9Ab7GyKNX X-Received: by 2002:a17:902:8649:: with SMTP id y9mr28192780plt.289.1563201446297; Mon, 15 Jul 2019 07:37:26 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id s66sm18381852pfs.8.2019.07.15.07.37.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 07:37:25 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Oleg Nesterov , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , c0d1n61at3@gmail.com, "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Josh Triplett , keescook@chromium.org, kernel-hardening@lists.openwall.com, kernel-team@android.com, Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, Mathieu Desnoyers , neilb@suse.com, netdev@vger.kernel.org, "Paul E. McKenney" , Pavel Machek , peterz@infradead.org, "Rafael J. Wysocki" , Rasmus Villemoes , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , will@kernel.org, x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Subject: [PATCH 3/9] rcu/sync: Remove custom check for reader-section (v2) Date: Mon, 15 Jul 2019 10:36:59 -0400 Message-Id: <20190715143705.117908-4-joel@joelfernandes.org> X-Mailer: git-send-email 2.22.0.510.g264f2c817a-goog In-Reply-To: <20190715143705.117908-1-joel@joelfernandes.org> References: <20190715143705.117908-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rcu/sync code was doing its own check whether we are in a reader section. With RCU consolidating flavors and the generic helper added in this series, this is no longer need. We can just use the generic helper and it results in a nice cleanup. Cc: Oleg Nesterov Acked-by: Oleg Nesterov Signed-off-by: Joel Fernandes (Google) --- include/linux/rcu_sync.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/rcu_sync.h b/include/linux/rcu_sync.h index 9b83865d24f9..0027d4c8087c 100644 --- a/include/linux/rcu_sync.h +++ b/include/linux/rcu_sync.h @@ -31,9 +31,7 @@ struct rcu_sync { */ static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) { - RCU_LOCKDEP_WARN(!rcu_read_lock_held() && - !rcu_read_lock_bh_held() && - !rcu_read_lock_sched_held(), + RCU_LOCKDEP_WARN(!rcu_read_lock_any_held(), "suspicious rcu_sync_is_idle() usage"); return !READ_ONCE(rsp->gp_state); /* GP_IDLE */ } -- 2.22.0.510.g264f2c817a-goog