Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4575643ybi; Mon, 15 Jul 2019 11:07:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKV3RHrZdkrN27eNBZIEsERV9BSo9eHaC1GoI2TTEXKrafEQ6RJDtOzZEW4dlQhYGfhnls X-Received: by 2002:a63:360d:: with SMTP id d13mr28314494pga.80.1563214044223; Mon, 15 Jul 2019 11:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563214044; cv=none; d=google.com; s=arc-20160816; b=ZDJVUjp0qglymNAIigNUQ/6qtEpnURIjF6vtLUgz0GR5AoRchaCY9nPh2Y2DtFWc1w vGyUHiyLlDQdN2/3rRH4MBY0gEze1Pn00tFmF9UD2q/KM2u+fp8Z2t0fu1utRPiNnKMr cf2fqbzSjjBEiMrndQvcn37NchzxH1exERr180S7V6A5Bl/q0XAuTpcHoWCyfZMP+/OB mYoQ/0W+5lRRXm4Qbydg7FXTNyS7vgEfQihOXNxxSJqjGZ8HVBPbwrqUNWvx/22ZJ8Aw ZZboUDG0IoZ2wGIxMdA4DNulTyT/cSJnNmuzWwqN3vtWJ7NguCCiSZy71QSIwEIj+JzK Kh1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=SsDakOjPFsI4+QXy2xkny4HlVN4PPgymejBBejoTxD8=; b=QzTjZJ6eBSIqI/dCfUDJAHQRvq/E/wwXjJxdiOcOVAW0iQ+0rM/Us2YiA6eXm4w70B +KR28iZsaQTa0F7ecg6nInjWD9aDwPoip2d6sVKCt49WdG1LsQWOj2kBsWixTl/LAQ8U 6qA+BhLNC0omzvDjUMmEqwsayYvlqpzSzeYilzJtb/SxPYAXe529J8URZH12ntGIpvSH R6K634846SvPkgcN0v6w1jhoEomsnv2PbV7AsPvw5AygJh2Rh6WKHxubISpmY292YJgl 8l/c9S2wzevYKXmuAsmJwtF0NmKU3qfhqB82kDggRfn/xF3c57jck9+MNnDRCd1qu6LM 07Bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u191si17199128pgd.281.2019.07.15.11.07.08; Mon, 15 Jul 2019 11:07:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731970AbfGOSGs (ORCPT + 99 others); Mon, 15 Jul 2019 14:06:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729277AbfGOSGs (ORCPT ); Mon, 15 Jul 2019 14:06:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DAF9914EB45A5; Mon, 15 Jul 2019 11:06:46 -0700 (PDT) Date: Mon, 15 Jul 2019 11:06:46 -0700 (PDT) Message-Id: <20190715.110646.1964036532467569670.davem@davemloft.net> To: huangfq.daxian@gmail.com Cc: jcliburn@gmail.com, chris.snook@gmail.com, michael.chan@broadcom.com, vishal@chelsio.com, fugang.duan@nxp.com, cooldavid@cooldavid.org, mlindner@marvell.com, stephen@networkplumber.org, tariqt@mellanox.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, jdmason@kudzu.us, manishc@marvell.com, rahulv@marvell.com, GR-Linux-NIC-Dev@marvell.com, chessman@tux.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v3 17/24] ethernet: remove redundant memset From: David Miller In-Reply-To: <20190715031911.6982-1-huangfq.daxian@gmail.com> References: <20190715031911.6982-1-huangfq.daxian@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jul 2019 11:06:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fuqian Huang Date: Mon, 15 Jul 2019 11:19:11 +0800 > kvzalloc already zeroes the memory during the allocation. > pci_alloc_consistent calls dma_alloc_coherent directly. > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So the memset after these function is not needed. > > Signed-off-by: Fuqian Huang Applied.