Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4575903ybi; Mon, 15 Jul 2019 11:07:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqx56lwqYiwvDJ6OpnHDaDTNIShypo3A3dKmaZMvKUZOxx3xfJ2O/RWg3dNBjuwcvkK0EXzF X-Received: by 2002:a17:902:8c98:: with SMTP id t24mr30606803plo.320.1563214058999; Mon, 15 Jul 2019 11:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563214058; cv=none; d=google.com; s=arc-20160816; b=KFIxEkPeCH4fB5u+QFtyJWL5VipkXRSHl5JZyKA9P8lVZw0/+0fnmYUXa+NiQhze3e 0Jn4rkcODSwGiXPSZZ4CFwYIIhTYDaOe7edz9f/WbCXNph43qOJ2VfNZtAATxmyfN7Mg wqM48hfI2OX/HZVUCEhlMO94h+f/qARC38eLU2bMabJ5qS9Sgrrf0i8kORyVcoN6BIo2 C3GvGkCiM8dNVn7zrvo9HevrK/qdhzixNcZRvUpI/0N+CiqVLO+2kNjBvSjuO4bm7DHp IJiYmsObmfl4Wb/Gx0kQJu+szd9xNIEx8P4DNXD5mVlIO9t0bKZiGW0sdK9BbarkN3Rn rkKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XbEZIV+A5ez5aMBCY/RZhHQh/uYvOEh6kt0m2WmtRgU=; b=EaAnN++uoSRAwhZX/jPEbUdIZJG8Z1mPq+Simm/jG+wpAmcaEzx8rygP58LyWO7Kjf uLqYPzUVVd5D7SVkUSnuI8mwDESet0e3EWtpmDvOtnh2tk49x1t55E80dmxE3+VJuyUy w/pjU6Gfb4hD4kdR0Y/bTEP66/ZLt60wb9GYtxsdseeUncMEKOGhSoqnzL7uqe3twZIh 6Ch/mNM95A+rh9a1DcjAnazoLARWSGBJePRCXwHj1Mtv43QUA5/LAPTD6EgW8QTNNs5q lFQbMi4ljAujk1UywRtkidwJ8LrF8KTIkcjFiKY3ulVeZLQqfS7mQXw7b6otc4IlJExo 08EQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b24si16731123pfd.156.2019.07.15.11.07.23; Mon, 15 Jul 2019 11:07:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732095AbfGOSGy (ORCPT + 99 others); Mon, 15 Jul 2019 14:06:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729277AbfGOSGw (ORCPT ); Mon, 15 Jul 2019 14:06:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3465E1476D09C; Mon, 15 Jul 2019 11:06:52 -0700 (PDT) Date: Mon, 15 Jul 2019 11:06:51 -0700 (PDT) Message-Id: <20190715.110651.1919532320008372502.davem@davemloft.net> To: huangfq.daxian@gmail.com Cc: jes@trained-monkey.org, linux-hippi@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 18/24] hippi: Remove call to memset after pci_alloc_consistent From: David Miller In-Reply-To: <20190715031921.7028-1-huangfq.daxian@gmail.com> References: <20190715031921.7028-1-huangfq.daxian@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jul 2019 11:06:52 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fuqian Huang Date: Mon, 15 Jul 2019 11:19:21 +0800 > pci_alloc_consistent calls dma_alloc_coherent directly. > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang Applied.