Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAPM=9tzJQ+26n_Df1eBPG1A=tXf4xNuVEjbG3aZj-aqYQ9nnAg@mail.gmail.com>
 <CAPM=9twvwhm318btWy_WkQxOcpRCzjpok52R8zPQxQrnQ8QzwQ@mail.gmail.com> <CAHk-=wjC3VX5hSeGRA1SCLjT+hewPbbG4vSJPFK7iy26z4QAyw@mail.gmail.com>
In-Reply-To: <CAHk-=wjC3VX5hSeGRA1SCLjT+hewPbbG4vSJPFK7iy26z4QAyw@mail.gmail.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Tue, 16 Jul 2019 04:27:59 +1000
Message-ID: <CAPM=9ty8kbEouQCwAedk+6jgByoiK4iBny=P_Hz9iB7Qy=dYww@mail.gmail.com>
Subject: Re: drm pull for v5.3-rc1
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Jerome Glisse <jglisse@redhat.com>,
        Thomas Hellstrom <thellstrom@vmware.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 16 Jul 2019 at 03:38, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Mon, Jul 15, 2019 at 12:08 AM Dave Airlie <airlied@gmail.com> wrote:
> >
> > VMware had some mm helpers go in via my tree (looking back I'm not
> > sure Thomas really secured enough acks on these, but I'm going with it
> > for now until I get push back).
>
> Yeah, this is the kind of completely unacceptable stuff that I was
> _afraid_ I'd get from the hmm tree, but didn't.

Looks like we were all focused on making sure hmm tree was good, I
really dropped the ball watching the other ball.

I pulled stuff in from Thomas quite a while ago, and his pull request
did say it had been looked at by mm devs, I looked back
a week or so ago before the flu hit me badly and went hey this isn't
as good, but removing it is a mess I better ping some people, then I
promptly fell into a hole.

It's bad though so I'm just going to revert it all out.

I'll send a new PR today with it reverted, rebuilding the tree might
be possible, but you'd lose a lot of testing confidence in the rest of
it.

> I'm not pulling this. Why did you merge it into your tree, when
> apparently you were aware of how questionable it is judging by the drm
> pull request.

I totally over trusted Thomas on this, I glanced at the helpers when I
merged them and went they seemed reasonable for the vmware address
space coherency model, and they'd been posted to linux-mm a few times
and had some feedback,

I caught it more last week when I was re-reviewing all the stuff in my
tree and I was like hey that isn't right, but removing it might be
tricky, then I spent a week with a couch and no brain.

So I'm totally responsible for this crap landing in my tree, and
Thomas will be getting a lot more push back in future.

Dave.