Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4672751ybi; Mon, 15 Jul 2019 12:47:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTfsiv92CLvLvYIP5crvjDo4KQjODEj+9NNglj15BGM4sMbfZuxqnXXrDH5TfHQrC5iV+/ X-Received: by 2002:a17:90a:80c4:: with SMTP id k4mr31519970pjw.74.1563220062673; Mon, 15 Jul 2019 12:47:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563220062; cv=none; d=google.com; s=arc-20160816; b=yz29jg/pZ1eXP0gulERwXBjaOO8S+s8MfWNMR6Bp4qM3ngbzT8yqg++UEmcSp3DwWS XQVAPi8z446WfE18+Gq0nzKCmDnr+1dKQk8gqGXuH+Yo+8E+8RuhkpCpN/mA5BlhtzZv kJPq2z5FrvB/7o1H41qEpOCFy+LAVQO0f4cnPEmw+L/KbLLddJwF436qdk8tM2gAdlOb +WbIb6IINlLHWnYOyqbd+FdK+5sEyeUxm7Ux/kwLK5bfQko4nXI/NBjRRQcFkG+oGHsR SgYZYRrfX4/PKNxL6h4HFQem5FIpJBZP34EWBdRcz4xYAdTKx1s/IeQxleG05ETz3Uib CG9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=C/B2NKgPKdj2Yh0SJwcgWFNtP4FI6Rhb6HqTFAgPj2E=; b=LIgn0wKAvCB/JpVNKdYcBRO+SE7HPJvKgMn2vCtSS0CWD4bw6N+xtmqV0tIzTX9Io+ yakUoldUf6t9ET3C+qqzRtBKwFOjvP3bjuZdrobXBba/Md7c8BTmNSL6wl62fSpyKYY0 RI8N65Mi3J8LwI98bQStkpWHHkh1wcS8ROf3ErTiPgdTuQbsvBt2GuD0ocxucTZr/qfC 1ULxLbmlaWYV9xvMgcTxv/m1XzmXeNwP/Wr47kYVFaUFdv4E7g4Zc2+AZ9/Bpp1AL0Cj EtuagI626Sp3OYQqvafG9/6c+bIWl0RmnvDZBc4728jTi3BYXoV9KJ/2HrDc0izM0teM sBfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9si15740764plp.4.2019.07.15.12.47.25; Mon, 15 Jul 2019 12:47:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730688AbfGOTqi (ORCPT + 99 others); Mon, 15 Jul 2019 15:46:38 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:48688 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729598AbfGOTqh (ORCPT ); Mon, 15 Jul 2019 15:46:37 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hn6vj-0005QV-5x; Mon, 15 Jul 2019 21:46:35 +0200 Date: Mon, 15 Jul 2019 21:46:33 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Uros Bizjak , linux-kernel@vger.kernel.org, x86@kernel.org, Andrew Lutomirski Subject: Re: [RFC PATCH, x86]: Disable CPA cache flush for selfsnoop targets In-Reply-To: <20190715193938.GG32439@tassilo.jf.intel.com> Message-ID: References: <8736j7gsza.fsf@linux.intel.com> <20190715193938.GG32439@tassilo.jf.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jul 2019, Andi Kleen wrote: > > Right, we don't know where the PAT invocation comes from and whether they > > are safe to omit flushing the cache. The module load code would be one > > obvious candidate. > > Module load just changes the writable/executable status, right? That shouldn't > need to flush in any case because it doesn't change the caching attributes. Ah right. We don't flush when the caching attributes are not changed. Thanks, tglx