Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190715164705.220693-1-henryburns@google.com>
 <CAMJBoFMS2BiCdBFBEGE_p5fovDphGqjDjaBYnfGFWhNvCnAvdQ@mail.gmail.com> <CAGQXPTh-Z664T3Uxak-CiRn6Mc-s=esRzURLpwQaN+v0RgxFyg@mail.gmail.com>
In-Reply-To: <CAGQXPTh-Z664T3Uxak-CiRn6Mc-s=esRzURLpwQaN+v0RgxFyg@mail.gmail.com>
From:   Henry Burns <henryburns@google.com>
Date:   Mon, 15 Jul 2019 14:21:23 -0700
Message-ID: <CAGQXPTi9qMCujvkM67Y28KiTP7xyGiR01ci9Yb6fgq8pW_tcFg@mail.gmail.com>
Subject: Re: [PATCH] mm/z3fold.c: Reinitialize zhdr structs after migration
To:     Vitaly Wool <vitalywool@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Vitaly Vul <vitaly.vul@sony.com>,
        Shakeel Butt <shakeelb@google.com>,
        Jonathan Adams <jwadams@google.com>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry Vitaly, I had the wrong impression from your email that
INIT_LIST_HEAD() was being ensured directly in migrate and got
confused. (I thought you were saying it happened through the call to
do_compact_page() queued).

That being said, I don't see where in migrate new_zhdr->buddy is being
checked. We do check for new_zhdr.work with
 if (work_pending(&zhdr->work)) {
...
}

Is that what you were referring to?