Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Sven Van Asbroeck <thesven73@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a
 reset-controller
Thread-Topic: [EXT] [PATCH v1] net: fec: optionally reset PHY via a
 reset-controller
Thread-Index: AQHVO1EEL3ng1jsYe0KS/0rCZTBO1KbMdjtA
Date:   Tue, 16 Jul 2019 02:02:05 +0000
Message-ID: <VI1PR0402MB36009E99D7361583702B84DDFFCE0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20190715210512.15823-1-TheSven73@gmail.com>
In-Reply-To: <20190715210512.15823-1-TheSven73@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bb4a3104-dcca-4405-fce2-08d709919a51
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 02:02:05.9157
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fugang.duan@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3406
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Sven Van Asbroeck <thesven73@gmail.com> Sent: Tuesday, July 16, 2019 =
5:05 AM
> The current fec driver allows the PHY to be reset via a gpio, specified i=
n the
> devicetree. However, some PHYs need to be reset in a more complex way.
>=20
> To accommodate such PHYs, allow an optional reset controller in the fec
> devicetree. If no reset controller is found, the fec will fall back to th=
e legacy
> reset behaviour.
>=20
> Example:
> &fec {
>         phy-mode =3D "rgmii";
>         resets =3D <&phy_reset>;
>         reset-names =3D "phy";
>         status =3D "okay";
> };
>=20
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
>=20
> Will send a Documentation patch if this receives a positive review.
>=20
>  drivers/net/ethernet/freescale/fec_main.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 38f10f7dcbc3..5a5f3ed6f16d 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -61,6 +61,7 @@
>  #include <linux/regulator/consumer.h>
>  #include <linux/if_vlan.h>
>  #include <linux/pinctrl/consumer.h>
> +#include <linux/reset.h>
>  #include <linux/prefetch.h>
>  #include <soc/imx/cpuidle.h>
>=20
> @@ -3335,6 +3336,7 @@ static int fec_enet_get_irq_cnt(struct
> platform_device *pdev)  static int  fec_probe(struct platform_device *pde=
v)
> {
> +       struct reset_control *phy_reset;
>         struct fec_enet_private *fep;
>         struct fec_platform_data *pdata;
>         struct net_device *ndev;
> @@ -3490,7 +3492,9 @@ fec_probe(struct platform_device *pdev)
>         pm_runtime_set_active(&pdev->dev);
>         pm_runtime_enable(&pdev->dev);
>=20
> -       ret =3D fec_reset_phy(pdev);
> +       phy_reset =3D devm_reset_control_get_exclusive(&pdev->dev,
> "phy");
> +       ret =3D IS_ERR(phy_reset) ? fec_reset_phy(pdev) :
> +                       reset_control_reset(phy_reset);
>         if (ret)
>                 goto failed_reset;

The patch looks fine.
But the reset mechanism in the driver should be abandoned since
the phylib already can handle mii bus reset and phy device reset like
below piece code:

of_mdiobus_register()
    of_mdiobus_register_phy()
        phy_device_register()
            mdiobus_register_device()
                /* Assert the reset signal */
                mdio_device_reset(mdiodev, 1);
            /* Deassert the reset signal */
            mdio_device_reset(&phydev->mdio, 0);

dts:
        ethernet-phy@0 {
            compatible =3D "ethernet-phy-id0141.0e90", "ethernet-phy-ieee80=
2.3-c45";
            interrupt-parent =3D <&PIC>;
            interrupts =3D <35 1>;
            reg =3D <0>;

            resets =3D <&rst 8>;
            reset-names =3D "phy";
            reset-gpios =3D <&gpio1 4 1>;
            reset-assert-us =3D <1000>;
            reset-deassert-us =3D <2000>;
        };
    };
           =20
Please refer to doc:
Documentation/devicetree/bindings/net/ethernet-phy.yaml
>=20
> --
> 2.17.1