Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp196359ybi; Mon, 15 Jul 2019 19:14:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKN5XU5kcYhory4PKz29X6AI+A1uR58oL/YGEWvyI81SJsc4Q5USt77pwS8VP4rnDu3RlC X-Received: by 2002:a63:de4f:: with SMTP id y15mr31434197pgi.239.1563243277986; Mon, 15 Jul 2019 19:14:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563243277; cv=none; d=google.com; s=arc-20160816; b=OnlRZCTCsfAcIXsKQwLfqVLOzWALayaIJ31QtaCwBY6GVuprC5pRagZB+ggbKN54EF X+QWhrf+vixCj7SJkkGlsSKUiWr1gCkGCc9sA/WilIavdbmtfWE/cY/UNv66qjDLpEMH 4dXom94vN9XioNti5ZJNfYNQ70t/tUQzdGZaUtlennxz5IG/EQbXNSj8wTOlud9dhH9K a2RNWMyg4RnvTXKqe+cuy6ug8VyJxbAMerY1+hkvOY4x6uvUW0nzSZ15geAwdRy8i+lP HklV3A8jyThRJQ0NG6VWy+lL7v037mO2ohpJR+OdlVqRTeqYBHbSyJt5A5E4cjDVEgsI TVcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fcae4D3n6olbTotrj0EMMfo6HpZGYQzJBgAPofAoKnQ=; b=R0Is0l1ohwoxnRoZ5YbfV7T8/z98niWSJ8gn28UVNitTrjairgQp47ZgEHvazC2Wk3 fsBSZm1vTLhcbZ5bXWfYX9jZPiGkAUXNR30u17u+R1vroRQRJAsxqOaEkNE6gFCoP7hL 4bewcIUJ8vh0f1Yk/Ja/phuQf9g27VEa8iFSJTnOv67+Aj9iTM04jfhvPDD6ng3PJtEf xC5Cckuf4niW9klCr7v1FPzq0Igm8UXcbAiNi36uPeV0HvfRNO46nEMGSAkfwTAZACc6 Zr2/F/iqO9YTtMJYSp5I7cdn/z/G35VaQQFyai23armfocP4e+EHA09mZLGk6mH3ZeU8 ur+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=otpIewzT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2si18718984pff.221.2019.07.15.19.14.21; Mon, 15 Jul 2019 19:14:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=otpIewzT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387405AbfGPCOA (ORCPT + 99 others); Mon, 15 Jul 2019 22:14:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:45106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733303AbfGPCOA (ORCPT ); Mon, 15 Jul 2019 22:14:00 -0400 Received: from localhost (unknown [88.128.80.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B527C20880; Tue, 16 Jul 2019 02:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563243239; bh=1WXPaLAxJOus0JflLOCmf91JljCoNLWlAUD7TSVunLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=otpIewzTS2BCt4D6NLKOkDkFrN+yl1xFmNapQfs4OCftxcE6ZgRSBnNEJBuUzAaNG DcJDE7j2jP0Sea0ksNgunMOHibyOErzZLgL5H2ifQOEASbJxod0S4w5YvIYppWMHiZ tRUfvtTj4oi8FKKc9OM2Bt1Opfve1sbf7Y/nVcTo= Date: Tue, 16 Jul 2019 04:12:01 +0200 From: Greg KH To: Tri Vo Cc: "Rafael J. Wysocki" , Viresh Kumar , "Rafael J. Wysocki" , Hridya Valsaraju , Sandeep Patil , kaleshsingh@google.com, LKML , Linux PM , "Cc: Android Kernel" Subject: Re: [PATCH v3] PM / wakeup: show wakeup sources stats in sysfs Message-ID: <20190716021201.GB8310@kroah.com> References: <20190715201116.221078-1-trong@android.com> <20190715203651.GA7513@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 15, 2019 at 02:48:13PM -0700, Tri Vo wrote: > > And I am guessing that you actually tested this all out, and it works > > for you? > > Yes, I played around with wakelocks to make sure that wakeup source > stats are added/updated/removed as expected. Great! > > Have you changed Android userspace to use the new api with no > > problems? > > Kalesh helped me test this patch (added him in Tested-by: field in > latest patch version). We haven't tested beyond booting and manual > inspection on android devices. Android userspace changes should be > fairly trivial though. Ok, I know some people wanted to do some premature optimization with the original discussion about this, glad to see it's not needed... thanks, greg k-h