Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one
To:     Ralph Campbell <rcampbell@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Jason Gunthorpe <jgg@mellanox.com>
References: <20190709223556.28908-1-rcampbell@nvidia.com>
 <20190709172823.9413bb2333363f7e33a471a0@linux-foundation.org>
 <05fffcad-cf5e-8f0c-f0c7-6ffbd2b10c2e@nvidia.com>
 <20190715150031.49c2846f4617f30bca5f043f@linux-foundation.org>
 <0ee5166a-26cd-a504-b9db-cffd082ecd38@nvidia.com>
 <8dd86951-f8b0-75c2-d738-5080343e5dc5@nvidia.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <6a52c2a0-8d27-2ce4-e797-7cae653df21a@nvidia.com>
Date:   Mon, 15 Jul 2019 23:14:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <8dd86951-f8b0-75c2-d738-5080343e5dc5@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/15/19 5:38 PM, Ralph Campbell wrote:
> On 7/15/19 4:34 PM, John Hubbard wrote:
>> On 7/15/19 3:00 PM, Andrew Morton wrote:
>>> On Tue, 9 Jul 2019 18:24:57 -0700 Ralph Campbell <rcampbell@nvidia.com>=
 wrote:
>>>
>>> =C2=A0 mm/rmap.c |=C2=A0=C2=A0=C2=A0 1 +
>>> =C2=A0 1 file changed, 1 insertion(+)
>>>
>>> --- a/mm/rmap.c~mm-hmm-fix-bad-subpage-pointer-in-try_to_unmap_one
>>> +++ a/mm/rmap.c
>>> @@ -1476,6 +1476,7 @@ static bool try_to_unmap_one(struct page
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 * No need to invalidate here it will synchronize on
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 * against the special swap migration pte.
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 */
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub=
page =3D page;
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 goto discard;
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>>
>> Hi Ralph and everyone,
>>
>> While the above prevents a crash, I'm concerned that it is still not
>> an accurate fix. This fix leads to repeatedly removing the rmap, against=
 the
>> same struct page, which is odd, and also doesn't directly address the
>> root cause, which I understand to be: this routine can't handle migratin=
g
>> the zero page properly--over and back, anyway. (We should also mention m=
ore
>> about how this is triggered, in the commit description.)
>>
>> I'll take a closer look at possible fixes (I have to step out for a bit)=
 soon,
>> but any more experienced help is also appreciated here.
>>
>> thanks,
>=20
> I'm not surprised at the confusion. It took me quite awhile to understand=
 how=20
> migrate_vma() works with ZONE_DEVICE private memory.
> The big point to be aware of is that when migrating a page to
> device private memory, the source page's page->mapping pointer
> is copied to the ZONE_DEVICE struct page and the page_mapcount()
> is increased. So, the kernel sees the page as being "mapped"
> but the page table entry as being is_swap_pte() so the CPU will fault
> if it tries to access the mapped address.

Thanks for humoring me here...

The part about the source page's page->mapping pointer being *copied*
to the ZONE_DEVICE struct page is particularly interesting, and belongs
maybe even in a comment (if not already there). Definitely at least in
the commit description, for now.

> So yes, the source anon page is unmapped, DMA'ed to the device,
> and then mapped again. Then on a CPU fault, the zone device page
> is unmapped, DMA'ed to system memory, and mapped again.
> The rmap_walk() is used to clear the temporary migration pte so
> that is another important detail of how migrate_vma() works.
> At the moment, only single anon private pages can migrate to
> device private memory so there are no subpages and setting it to "page"
> should be correct for now. I'm looking at supporting migration of
> transparent huge pages but that is a work in progress.

Well here, I worry, because subpage !=3D tail page, right? subpage is a
strange variable name, and here it is used to record the page that
corresponds to *each* mapping that is found during the reverse page
mapping walk.

And that makes me suspect that if there were more than one of these
found (which is unlikely, given the light testing that we have available
so far, I realize), then there could possibly be a problem with the fix,
yes?

> Let me know how much of all that you think should be in the change log.
> Getting an Acked-by from Jerome would be nice too.
>=20
> I see Christoph Hellwig got confused by this too [1].

Yeah, him and me both. :)

> I have a patch to clear page->mapping when freeing ZONE_DEVICE private
> struct pages which I'll send out soon.
> I'll probably also add some comments to struct page to include the
> above info and maybe remove the _zd_pad_1 field.
>=20
> [1] 740d6310ed4cd5c78e63 ("mm: don't clear ->mapping in hmm_devmem_free")
>=20

That's  b7a523109fb5c9d2d6dd3ffc1fa38a4f48c6f842 in linux.git, now.

thanks,
--=20
John Hubbard
NVIDIA