Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp719613ybi; Tue, 16 Jul 2019 04:17:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzs55X64K1lpwysu/vYqflkdPD/a4keG+1LVlAdYKocxJLjkOkkzEvcVv5BYtmaCRDyCsUJ X-Received: by 2002:a63:553:: with SMTP id 80mr33792787pgf.280.1563275867504; Tue, 16 Jul 2019 04:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563275867; cv=none; d=google.com; s=arc-20160816; b=tkg5Amfh0tB6dzauEXlzn7gmxUktNeihSCpyjJrGogJBN7oYnQhv5mj0ptL1kHXw+d fo5KwxUyeDoXUvWC0FQLThSimW2ah8+Ff2PiRbtewk31cTBVE9LJoqZn6Tz31uABBMMv C9Q9BnHAcpZ9YQ2HT5b7Z+tdtlQ4k+NE9IwsPs/H3kns6D302Wtt7Jc61lYb8Pl51PP6 Tfwj53K2tAA3JkoIdoNUhSx0vHfYe1gi6fOZ6pQzMPQAfCjYHd0U+RfULffVHd1oWTim IxSKI+JYKDTfmDae3fVDvx7DXdvAobwgpc/VAk//y4Dqoho/PLcb4DcmeJHrMH8Au47+ dJAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=2TzI92jREEAisjez3s3Tyq7BlY9iC2zif76m3qulrxk=; b=bBk2GUG0Ct8hcVSissxL7KMhTnR0yUs9XTSEGSqXZnACBVXrQbZ40wzouKUsBHJ/iR Gxeuj0mB/iZyppJQ2JUWEVu12c1qtdemRtqaakTAS58nwh9d5c7CuOPhP0MA/X5L4hlu 03e4QzhxqmHFDWV9pNeLdgnd/oxsEoVjSbVi5SYlSOwIKZRtRuuDKlXi4CIIyaadnNmy 942uJ9ssWGSMZ2wJIAgQRNMCJnjZ1060wXiHF/kX+SllzihqX+sXoyhy3TgZI5ZxW60V UpfvOtuNzD2B6nHShviCzLsBUB9Kx9ey2V89kfbFcUcXAtgXW4JBKh6sBhG8bPDvrFzd xC8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si20992914pgm.43.2019.07.16.04.17.31; Tue, 16 Jul 2019 04:17:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387655AbfGPLQm (ORCPT + 99 others); Tue, 16 Jul 2019 07:16:42 -0400 Received: from mail.us.es ([193.147.175.20]:41814 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387619AbfGPLQl (ORCPT ); Tue, 16 Jul 2019 07:16:41 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id CBE8B20A52D for ; Tue, 16 Jul 2019 13:16:39 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BB8CB1150CC for ; Tue, 16 Jul 2019 13:16:39 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id B01F2A59B; Tue, 16 Jul 2019 13:16:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B31C0A6DA; Tue, 16 Jul 2019 13:16:37 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 16 Jul 2019 13:16:37 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 82CC84265A2F; Tue, 16 Jul 2019 13:16:37 +0200 (CEST) Date: Tue, 16 Jul 2019 13:16:37 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Miaohe Lin Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mingfangsen@huawei.com Subject: Re: [PATCH v5] net: netfilter: Fix rpfilter dropping vrf packets by mistake Message-ID: <20190716111637.s24hwb6a6bjlhdiq@salvia> References: <1562039976-203880-1-git-send-email-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562039976-203880-1-git-send-email-linmiaohe@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 02, 2019 at 03:59:36AM +0000, Miaohe Lin wrote: > When firewalld is enabled with ipv4/ipv6 rpfilter, vrf > ipv4/ipv6 packets will be dropped. Vrf device will pass > through netfilter hook twice. One with enslaved device > and another one with l3 master device. So in device may > dismatch witch out device because out device is always > enslaved device.So failed with the check of the rpfilter > and drop the packets by mistake. Applied to nf.git, thanks.