Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp869959ybi; Tue, 16 Jul 2019 06:26:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLklJi85YN4Sz3QYRUncI2jGpx0+RUlk5MPmWBWJuaY7Qp2ZZVTOFs5dEbDpMy7Z7R86AU X-Received: by 2002:a17:902:7c05:: with SMTP id x5mr35736610pll.321.1563283601999; Tue, 16 Jul 2019 06:26:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563283601; cv=none; d=google.com; s=arc-20160816; b=L9B8GyRxmAGkmRIwh5msulFJSUDfzDMnACiAhKRRofWz27oLDUW1+Pyvz8zXDUZy/8 IuyaDE5GLKVq7KFyBFhhS2bMekUnVT5PAhtTHycQpHDkZKZFCfjEva9MKiPjHTEqp9TB wKMPS9rafrJ4HHaJNTU1x7lIdVTQBFErlG2LJNCfnszTRrJfoEsoblxhFQDiLzU1Rbdj HOEvtmS0s9TTPneNY+MAX+mPOQobjVxU+zO+vZUkugYCWZ105tfPp5Dm4x3WOiI/Ytfc +W6U9ESaXIK+6Fpw3+XlBxz7nfBzPrUHCvnTnx0cehJFo1goUN1PNNie1yGHChL7zmLZ OzyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:dkim-signature; bh=Vbkrp6w7m4D6pHF3/AKyST3n0EHCDNA9AqE+moGYREY=; b=PEtxmkqmt41hYhPMZ7a4tmsE3qZKk3Vx4BqWSBCKoRrTBEeHGIV3Ema9lDk+U/m157 p8nIJhmfTIwxBTVOgToU2wsFUbV37+unq0/zjRlCqHBGH17IsMI+cR2bModakYSyZo9X CJXND8AcjDpaW6xpryCvj53ySvnQ2lFK3csn1VRa8rASo17TLgvnjky3zZKwtx3TMEhQ N7OBaSxQUicuViB2eW4xYlNYoaK9hgH6ZSWGe7exWfTC8rJkHOFXW6tHuK7U+Cqwj/9P sHeAP09H5M/79/0qN11UHjAJj3IpmaUOkH24arO1tGvUnpytn2Bn+sMnK7bYvxwCx6Mq 0HPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@fpond.eu header.s=strato-dkim-0002 header.b=gzjz7PnK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si19506682pgl.499.2019.07.16.06.26.25; Tue, 16 Jul 2019 06:26:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@fpond.eu header.s=strato-dkim-0002 header.b=gzjz7PnK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387445AbfGPNYb (ORCPT + 99 others); Tue, 16 Jul 2019 09:24:31 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([81.169.146.169]:33272 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfGPNYb (ORCPT ); Tue, 16 Jul 2019 09:24:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1563283469; s=strato-dkim-0002; d=fpond.eu; h=Subject:References:In-Reply-To:Message-ID:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=Vbkrp6w7m4D6pHF3/AKyST3n0EHCDNA9AqE+moGYREY=; b=gzjz7PnKJCwPNyS3onMlyFrexdC+kKgtwyNcVptNh7PY25uuL2naIBp6noDqoXoHPk 5vsQibyyNIKFnZKLCgUu+tqpvlG/3arrx7t5fFJpuQEMeLFv5t7h/6aFEDYBcLdUMKyu PT4wB2iBA2P83tKCldixyYn5C6PLatzI6x2K4Zi14Z288mENZUJHxpeM4X9GiIoUJL5m 7QQOHXkiVTV6CJ8N4I/8F3KKIF3jOEesH/IHK3kZ+xlMUdfiOL4q5odq6GSI9ZAFY+rG 07C+u65AwidsP3y10unOWZna1blAY/Jp7RbqixBw0sIuJ8YbW4+u0xPPc/kBt3nDowYe HPtg== X-RZG-AUTH: ":OWANVUa4dPFUgKR/3dpvnYP0Np73amq+g13rqGzmt2bYDnKIKaws6YXTsc4=" X-RZG-CLASS-ID: mo00 Received: from oxapp06-01.back.ox.d0m.de by smtp-ox.front (RZmta 44.24 AUTH) with ESMTPSA id h0a328v6GDITcPy (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 16 Jul 2019 15:18:29 +0200 (CEST) Date: Tue, 16 Jul 2019 15:18:29 +0200 (CEST) From: Ulrich Hecht To: Jacopo Mondi , laurent.pinchart@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch Cc: koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <1992958141.61517.1563283109549@webmail.strato.com> In-Reply-To: <20190706140746.29132-16-jacopo+renesas@jmondi.org> References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-16-jacopo+renesas@jmondi.org> Subject: Re: [PATCH v2 15/19] drm: rcar-du: Claim CMM support for Gen3 SoCs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev59 X-Originating-IP: 85.212.152.154 X-Originating-Client: open-xchange-appsuite Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On July 6, 2019 at 4:07 PM Jacopo Mondi wrote: > > > Add CMM to the list of supported features for Gen3 SoCs that provide it: > - R8A7795 > - R8A7796 > - R8A77965 > - R8A7799x > > Leave R8A77970 out as V3M and V3H are the only Gen3 SoCs that do not > support CMM. > > Signed-off-by: Jacopo Mondi > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 12 ++++++++---- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 75ab17af13a9..1e69cfa11798 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -247,7 +247,8 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(3) | BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > @@ -280,7 +281,8 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > @@ -309,7 +311,8 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(3) | BIT(1) | BIT(0), > .routes = { > /* > @@ -357,7 +360,8 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = { > static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > .gen = 3, > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > - | RCAR_DU_FEATURE_VSP1_SOURCE, > + | RCAR_DU_FEATURE_VSP1_SOURCE > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(1) | BIT(0), > .routes = { > /* > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > index 1327cd0df90a..a00dccc447aa 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -28,6 +28,7 @@ struct rcar_du_encoder; > #define RCAR_DU_FEATURE_VSP1_SOURCE BIT(1) /* Has inputs from VSP1 */ > #define RCAR_DU_FEATURE_INTERLACED BIT(2) /* HW supports interlaced */ > #define RCAR_DU_FEATURE_TVM_SYNC BIT(3) /* Has TV switch/sync modes */ > +#define RCAR_DU_FEATURE_CMM BIT(4) /* Has CMM */ > > #define RCAR_DU_QUIRK_ALIGN_128B BIT(0) /* Align pitches to 128 bytes */ > > -- > 2.21.0 > Reviewed-by: Ulrich Hecht CU Uli