Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1029232ybi; Tue, 16 Jul 2019 08:36:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxuCCLpTBkw3o1vGR8A9wGM+ik1l+9NZCCbNQP+84tLzAs2xRWoIIwyA+9Q8p0X0E+deoA8 X-Received: by 2002:a65:4546:: with SMTP id x6mr34237802pgr.266.1563291411902; Tue, 16 Jul 2019 08:36:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563291411; cv=none; d=google.com; s=arc-20160816; b=AqVTMrK+Rds3xZECJAdfnm9TdpTuQhDdf0xNqUfAPYBRovEr9CbRuk+Paulfd3vto4 630BBmc/ngwIZ+uOX1nli8if7HLUYBewf/Y1hXoBBDUx/9nFBH3Gd6Wa1EH34rwSymIQ +2f+kiAI/Ja4JB+2BWrx7SPAOF8UWwmwHpsl0RYzMyg8IsFNQzVk3shRqmGcdDNGqVbj 0kwTtwcsnZ5jBrJguZV08RLnuQiJ8EGXRB6n1ZjJmd5JVc6/SsuUkRkmraKDDzfaovJq Jx+q1AjIdfXcPHZZuFbTk6bZlSMJHrdFd9i3v0OlnPWOHq7hV4EkG1Ki1ryR1cAAlhGF TQKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=N0c4Ne0w5IHep5TbscqbsMR9SqladIx9f8trc3aDEqw=; b=ZGKwNxHaCGvzMlRp8C/4MmloJOYBuzY1gYDZeFRocuf2Ymzzy/8QOLSKiM71CC/a6O l6/vnTSEUAcZXkYcvsS1iOu19hF88TzQcpFIBj/N5RJvf6Jhf513oGgZq0+9rbyoEnyd uSGhOHf7gkYFBoJUAoio0VCzrwr+5OG2Pjvpj/QkEt1Gel6wa2bxN5muiV1gPNe2U8PT 7Rv16v0zPHdF8c8Ce4SfugS8/dr3+jpXa1MOcahCbPcYnuAUdpfAs3j063V3VaMcrLPP 08Q7Ufb8Dl1z+arDO8l02gAMIe38Etd+h7now3gJP7OY66Pt/4epozZpzBhf5RMPdeb8 CsUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h13si18672440pgp.296.2019.07.16.08.36.34; Tue, 16 Jul 2019 08:36:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbfGPPgN convert rfc822-to-8bit (ORCPT + 99 others); Tue, 16 Jul 2019 11:36:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:46480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725926AbfGPPgN (ORCPT ); Tue, 16 Jul 2019 11:36:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 55CEEAF1E; Tue, 16 Jul 2019 15:36:12 +0000 (UTC) Date: Tue, 16 Jul 2019 17:36:10 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Patrick Bellasi Cc: Alessio Balsini , Dietmar Eggemann , Morten Rasmussen , Quentin Perret , Joel Fernandes , Paul Turner , Steve Muckle , Suren Baghdasaryan , Todd Kjos , Peter Zijlstra , "Rafael J . Wysocki" , Tejun Heo , Vincent Guittot , Viresh Kumar , Juri Lelli , Ingo Molnar , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v11 3/5] sched/core: uclamp: Propagate system defaults to root group Message-ID: <20190716153610.GE32540@blackbody.suse.cz> References: <20190708084357.12944-1-patrick.bellasi@arm.com> <20190708084357.12944-4-patrick.bellasi@arm.com> <20190715164226.GA30262@blackbody.suse.cz> <20190716143417.us3xhksrsaxsl2ok@e110439-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20190716143417.us3xhksrsaxsl2ok@e110439-lin> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 16, 2019 at 03:34:17PM +0100, Patrick Bellasi wrote: > > cpu_util_update_eff internally calls css_for_each_descendant_pre() so > > this should be protected with rcu_read_lock(). > > Right, good catch! Will add in v12. When I responded to your other patch, it occurred to me that since cpu_util_update_eff goes writing down to child csses, it should take also uclamp_mutex here to avoid race with direct cgroup attribute writers.