Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1041174ybi; Tue, 16 Jul 2019 08:47:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBXgeUxkvIBfjm9bj2E6IYUeskJpGr0LfZnypgWXgjtg0ruaYmCoavcIN6VrsxCh0B3txR X-Received: by 2002:a63:784c:: with SMTP id t73mr35776733pgc.268.1563292063068; Tue, 16 Jul 2019 08:47:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563292063; cv=none; d=google.com; s=arc-20160816; b=IeqpyZ1pT4Em3+p6twmvXBj3UdZGDVlljrj6caSx4vuftc9GVAgeilEW2FHlIwdAIL JZIOBXyVbeuA8SABPC8pdhaPzWoE2q14vz/kkeUY7sEBNNXuw+UQ3TP6E3LHC+XMhLm0 qXW8Wy9jAYbmPsunq4p1GFZIBz3Cee0Pdp/yf/A+id/D6KtyIaNBPohyFV52Zi+/VWsp /m0GbBubmrjjUgGhZajc6cRfcDdpEdaBrJ/AUUOTPbsmEJSaTsVCkGouAwEXDYOeem2p 8T5UQ80Fn9YgE2Y0Knz4UUvLAwYC/ab6Z5bLWiOfaZSs5qM51uD5pgDjaSjhPJbs31nt ZMMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ARwvly3xwsWlnW4nq8Tw39sGQhiStpDzdFKHa3jqRs8=; b=ny710WuY7se7bopT4WA4hvrCjJr+uO9A07P+KFodYR5NbLvJO8vfIZm14wHzlGJout rLUD+MwnIj+Cg3fXjaEVYnlfZq7kzpXnFGd60aTNMIJnVBSSBuy1Uwzh5xMjfSlLxqcA 6yz/Hs4/0qczvRRaGE7ykAWaNugHUnLN1O0nf1rigzg58QWtB3GMkjgSD6di0qE3CLkA 8maWzgAMvKix+Iltm1zzasmtnV0a/aHa5/XKeExciUzaN/WL/fJAKV/BuRVldxGiunlV 7gInVOKCFbVSl7scHdu6shHSxS5Js33/wxZwMFFcOIlOpbPntPHkjs+w3Wf9CtOkljfF ABXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=egoUIDoK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c139si22570864pfb.140.2019.07.16.08.47.26; Tue, 16 Jul 2019 08:47:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=egoUIDoK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732614AbfGPPqb (ORCPT + 99 others); Tue, 16 Jul 2019 11:46:31 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:44311 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728121AbfGPPqb (ORCPT ); Tue, 16 Jul 2019 11:46:31 -0400 Received: by mail-qt1-f193.google.com with SMTP id 44so19997440qtg.11 for ; Tue, 16 Jul 2019 08:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ARwvly3xwsWlnW4nq8Tw39sGQhiStpDzdFKHa3jqRs8=; b=egoUIDoKaQ93O5g9QejhvqI+xj0QAvO5onVphqrCu4SMfp8U3Sr27VVDTyRAwcR6ld 3FQZj0AoySjmNrVQ/PD1ImxXC5uaUR5OtDSQIOjt48tVwbeyGUBseT565/CduKweSiEo 6UQjdoxM23yWidB52wzrkA+XIqoGJk138512dI3P9yiPq3qbMW2ujFo840r2cch6OoTK VUVdzt3qQiyQwrw5G1zl6Mq0pTz6ufM+NzClNaVD7lmwH/FDMf9bjUe3vUtbUJGiNQUd fBBs6UpGGJjClHsVxrfguvJFVGG0aA392M0qyVUlPEwANAwOGWOxjh+AcI/Cq0rueOyw sKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ARwvly3xwsWlnW4nq8Tw39sGQhiStpDzdFKHa3jqRs8=; b=o4YH7fpPcdVdecSxVrt6HSIfqOIoe9IDuKVw1foX+Y8ZHsTCX/bvwZ7DMHVbKlW5gE obQHZxzB9+NCI0FYt+tb3w6IaYtt3Jed5TMAkvLEYyeMV11pHS/TqWs446ygGAErsCbs edR97OdCH4R8XTbHBIMi+TgU+fW2Bme4EpQgFZyrx+UXbRS8GXgeK7X+IvYV5t1Lbt0y ps8RT8L90T0xVNgh4RUKZv2L49Nca59YG2RYabJN/qDWU95GDHLv8yvc5HofdB/rhazF /qf09UWCCmqOM53LS5hka7Wf9zzskYbt9Svz57gk3x/W7VwtxoorOAXZPXSsa3IYX6sV Hckw== X-Gm-Message-State: APjAAAVlMe9uJUxvXe5kYxYc0kN/1AEl0DRvU4kGBEFh5PJTpjLX0CrW Xo8OsikqtCtGQTDJvllqrQFmBDK676J817FmWt1S8g== X-Received: by 2002:aed:21f0:: with SMTP id m45mr23344348qtc.391.1563291989631; Tue, 16 Jul 2019 08:46:29 -0700 (PDT) MIME-Version: 1.0 References: <20190708084357.12944-1-patrick.bellasi@arm.com> <20190708084357.12944-4-patrick.bellasi@arm.com> <20190715164226.GA30262@blackbody.suse.cz> <20190716143417.us3xhksrsaxsl2ok@e110439-lin> In-Reply-To: <20190716143417.us3xhksrsaxsl2ok@e110439-lin> From: Joel Fernandes Date: Tue, 16 Jul 2019 11:46:18 -0400 Message-ID: Subject: Re: [PATCH v11 3/5] sched/core: uclamp: Propagate system defaults to root group To: Patrick Bellasi Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , LKML , Linux PM , Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Steve Muckle , Suren Baghdasaryan , Alessio Balsini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 16, 2019 at 10:34 AM Patrick Bellasi wrote: > > On 15-Jul 18:42, Michal Koutn=C3=BD wrote: > > On Mon, Jul 08, 2019 at 09:43:55AM +0100, Patrick Bellasi wrote: > > > +static void uclamp_update_root_tg(void) > > > +{ > > > + struct task_group *tg =3D &root_task_group; > > > + > > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MIN], > > > + sysctl_sched_uclamp_util_min, false); > > > + uclamp_se_set(&tg->uclamp_req[UCLAMP_MAX], > > > + sysctl_sched_uclamp_util_max, false); > > > + > > > + cpu_util_update_eff(&root_task_group.css); > > > +} > > cpu_util_update_eff internally calls css_for_each_descendant_pre() so > > this should be protected with rcu_read_lock(). > > Right, good catch! Will add in v12. > Hopefully these can catch it in the near future! https://lore.kernel.org/rcu/20190715143705.117908-1-joel@joelfernandes.org/= T/#t