Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1054724ybi; Tue, 16 Jul 2019 09:00:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKvcebrvieRjEKYtpr9XmRB70PAdwxexXEW3mb51Kzt3NK2clnpsesDskVQ0aWh00kg6+y X-Received: by 2002:a65:68c9:: with SMTP id k9mr3116963pgt.17.1563292828223; Tue, 16 Jul 2019 09:00:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563292828; cv=none; d=google.com; s=arc-20160816; b=XeMaSUwosYNR/xUHY4YKwZ031JJGugw9ywH4wX0VFYyibmyc8IuHt9EFxIJtqfQNee ImVOpyeQc9NQor4fsEFyyRa+V9y4q84sWvkMUEPAYMWPNGhZ21ivrS3VFRH9zBeeFAfp QFBu1lC16Q9Y2WDg/C/ZZKgCeLSTRaFyyobX3AecsYLQJU0AVpa/6ht0XhgxMogDc7Bb Gkrl200LZw+mv2DF1GrAf8zaeYFYL9nJqfpOXNXboSGm7DhKP6oTnsSHYj10O2EfLaKc TuWPqwucxJcQJGTOmrEo6ZFpasGBrEUVCaGjiFAKPIZFdrfpQf8me3adD5N3HzCnnkpe HHrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=tMHaQdR7Rdr3sQC2CoE3D7yvxi28T3ECf4EfUwe9uDQ=; b=qwID9xK0LqDC8GVOlCZt4m4qDlw9v5dJo1loZCRw0u938lpjs75KuxUT4+9aNmpFYK 1vaWAczKaEVdkY3wNYMVv7opSUgLi5eoEb4jolvif610GApDJNgQ5sz1UPtNmFwB01hC g21vWqKE/2KZkTf6GeMVx/IsSNzV53ZWOxnP3uW5bEftSlOEMH+qhCRKKsGNHxrFtogC ezK9be/hsd6bvZK+12dRCxkYQmWUoajBF/765TbIKzRbd+/U9GBXmtCEf2DEvCu1Y3VH /hKc8ThkvZGTPJsU/2W4f965UNhnUgD9KdGOVx+eTT6AVgroXkes4vyI1yJR8L1G2sFC x4rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si19342622plf.156.2019.07.16.09.00.11; Tue, 16 Jul 2019 09:00:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387949AbfGPP6Q (ORCPT + 99 others); Tue, 16 Jul 2019 11:58:16 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:52773 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728121AbfGPP6Q (ORCPT ); Tue, 16 Jul 2019 11:58:16 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1hnPqC-00053c-JT; Tue, 16 Jul 2019 17:58:08 +0200 Message-ID: <1563292685.2676.12.camel@pengutronix.de> Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes From: Lucas Stach To: Daniel Baluta , Angus Ainslie Cc: Mark Rutland , Devicetree List , Andra Danciu , Abel Vesa , Anson Huang , Carlo Caione , andrew.smirnov@gmail.com, Fabio Estevam , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , Guido =?ISO-8859-1?Q?G=FCnther?= , linux-arm-kernel Date: Tue, 16 Jul 2019 17:58:05 +0200 In-Reply-To: References: <20190702132353.18632-1-andradanciu1997@gmail.com> <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> <9e196ce51eac9ce9c327198c4a2911a8@www.akkea.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Am Mittwoch, den 03.07.2019, 16:25 +0300 schrieb Daniel Baluta: > > On Wed, Jul 3, 2019 at 4:12 PM Angus Ainslie wrote: > > > > Hi Daniel, > > > > On 2019-07-03 07:10, Daniel Baluta wrote: > > > > > > On Wed, Jul 3, 2019 at 4:01 PM Angus Ainslie wrote: > > > > > > > > Hi Andra, > > > > > > > > I tried this out on linux-next and I'm not able to record or play > > > > sound. > > > > > > > > I also added the sai2 entry to test out our devkit and get a PCM > > > > timeout > > > > with that. > > > > > > Hi Angus, > > > > > > There are still lots of SAI patches that need to be upstream. Me and > > > Andra > > > will be working on that over this summer. > > > > > > > > > > > On 2019-07-02 07:23, Andra Danciu wrote: > > > > > SAI3 and SAI6 nodes are used to connect to an external codec. > > > > > They have 1 Tx and 1 Rx dataline. > > > > > > > > > > > > > > > Cc: Daniel Baluta > > > > > > > > > > Signed-off-by: Andra Danciu > > > > > --- > > > > > Changes since v2: > > > > >       - removed multiple new lines > > > > > > > > > > Changes since v1: > > > > >       - Added sai3 node because we need it to enable audio on pico-pi-8m > > > > >       - Added commit description > > > > > > > > > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29 > > > > > +++++++++++++++++++++++++++++ > > > > >  1 file changed, 29 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > index d09b808eff87..736cf81b695e 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > @@ -278,6 +278,20 @@ > > > > >                       #size-cells = <1>; > > > > >                       ranges = <0x30000000 0x30000000 0x400000>; > > > > > > > > > > > > > > > +                     sai6: sai@30030000 { > > > > > +                             compatible = "fsl,imx8mq-sai", > > > > > > > > I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't > > > > the registers at a different offset from "fsl,imx6sx-sai". > > > > > > Yes, you are right on this. We are trying to slowly push all our > > > internal-tree > > > patches to mainline. Obviously, with started with low hanging fruits, > > > DTS > > > nodes and small SAI fixes. > > > > > > Soon, we will start to send patches for SAI IP ipgrade for imx8. > > > > > > > > > > > How is this supposed to work ? > > > > > > > > > > For the moment it won't work unless we will upstream all our SAI > > > internal patches. > > > But we will get there hopefully this summer. > > > > > > > Shouldn't a working driver be upstream before enabling it in the > > devicetree ? > > I see your point here and maybe your suggestion is the ideal > way to do things. > > Anyhow, I don't see a problem with adding the node in dts > because CONFIG_FSL_SAI is not set in the default config. > > We try to speedup the upstreaming process giving the fact > that SAI patches will go through audio maintainer's tree and > the DTS patches will most likely go through Shawn's tree. I've also looked at adding audio support to one of the custom boards I have here and was caught a bit off guard by the fact that the SAI driver is totally broken for i.MX8M due to missing patches, as I assumed the necessary bits are in place before the DT patches are landed. It's certainly not how things are usually done. This also means the DT description of the SAI nodes is wrong, as they are actually not compatible to the "fsl,imx6sx-sai". The register layout is moved around, so there is no point in claiming any backwards compat with the old SAI version. Do you have an ETA when the necessary patches for the i.MX8M SAI will be available for test and review? Regards, Lucas