Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: kpc2000: whitespace and line length cleanup
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <john.hubbard@gmail.com>
CC:     Dan Carpenter <dan.carpenter@oracle.com>,
        <devel@driverdev.osuosl.org>, Vandana BN <bnvandana@gmail.com>,
        Geordan Neukum <gneukum1@gmail.com>,
        Bharath Vedartham <linux.bhar@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Simon_Sandstr=c3=b6m?= <simon@nikanor.nu>
References: <20190715212123.432-1-jhubbard@nvidia.com>
 <20190715212123.432-2-jhubbard@nvidia.com> <20190716083653.GB26457@kroah.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <76dbf8b5-6819-46d6-3e88-6efd3e65c10f@nvidia.com>
Date:   Tue, 16 Jul 2019 11:02:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190716083653.GB26457@kroah.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/16/19 1:36 AM, Greg Kroah-Hartman wrote:
> On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
...
>>  drivers/staging/kpc2000/kpc2000_i2c.c         | 189 +++++++++++------
>>  drivers/staging/kpc2000/kpc2000_spi.c         | 116 +++++-----
>>  drivers/staging/kpc2000/kpc_dma/dma.c         | 109 ++++++----
>>  drivers/staging/kpc2000/kpc_dma/fileops.c     | 199 +++++++++++-------
>>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  | 113 +++++-----
>>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.h  | 156 +++++++-------
>>  6 files changed, 509 insertions(+), 373 deletions(-)
> 
> THat's way too many different types of changes to do all at once, and
> some of these are making the code look worse, not better.
> 
> There's a reason we don't run lindent :)

Yes, I am seeing that very clearly now. :)

> 
> If you want to do one-type-of-fix-per-patch, I'll gladly take these,
> otherwise, I recommend leaving this for those people learning how to do
> development to do.
> 

OK, I'm going to pretend that I'm not one of those people, despite recent
hard evidence to the contrary here. haha. Anyway, this does present a
nice set of things for new developers to get started on. So I'll leave
it as is.

thanks,
-- 
John Hubbard
NVIDIA