Subject: Re: [PATCH] CPU frequency display in /proc/cpuinfo
From: Lee Revell <rlrevell@joe-job.com>
To: Andi Kleen <ak@suse.de>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
       Andrew Morton <akpm@osdl.org>, Dave Jones <davej@redhat.com>,
       cpufreq <cpufreq@www.linux.org.uk>,
       linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20051204183239.GE14247@wotan.suse.de>
References: <20051202181927.GD9766@wotan.suse.de>
	 <20051202104320.A5234@unix-os.sc.intel.com>
	 <20051204164335.GB32492@isilmar.linta.de>
	 <20051204183239.GE14247@wotan.suse.de>
Content-Type: text/plain
Date: Sun, 04 Dec 2005 14:49:26 -0500
Message-Id: <1133725767.19768.12.camel@mindpipe>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1057
Lines: 24

On Sun, 2005-12-04 at 19:32 +0100, Andi Kleen wrote:
> On Sun, Dec 04, 2005 at 05:43:35PM +0100, Dominik Brodowski wrote:
> > On Fri, Dec 02, 2005 at 10:43:20AM -0800, Venkatesh Pallipadi wrote:
> > > The patch below changes this to:
> > > Show the last known frequency of the particular CPU, when cpufreq is present. If
> > > cpu doesnot support changing of frequency through cpufreq, then boot frequency 
> > > will be shown. The patch affects i386, x86_64 and ia64 architectures.
> > 
> > Looks good to me -- however, might this affect userspace cpufreq tools? I'd
> 
> They normally use /sys anyways.

Wrong, lots of userspace programs that need to know the CPU speed get it
from /proc/cpuinfo.  It would be nice if there were a better API.

As long as you don't change the file format it should be OK.

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/