Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 4/5] x86/paravirt: Remove const mark from
 x86_hyper_xen_hvm variable
To:     Zhenzhong Duan <zhenzhong.duan@oracle.com>,
        linux-kernel@vger.kernel.org
Cc:     bp@alien8.de, sstabellini@kernel.org, tglx@linutronix.de,
        xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
        mingo@redhat.com
References: <1562846532-32152-1-git-send-email-zhenzhong.duan@oracle.com>
 <1562846532-32152-5-git-send-email-zhenzhong.duan@oracle.com>
 <2433589d-a2d2-6b51-cfbd-c1141014ab93@suse.com>
 <67261f6e-5dce-2452-a6d6-aa6ca73dfeec@oracle.com>
From:   Juergen Gross <jgross@suse.com>
Message-ID: <06b1e979-3ac6-1f3c-616f-5756ac16519b@suse.com>
Date:   Wed, 17 Jul 2019 05:34:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <67261f6e-5dce-2452-a6d6-aa6ca73dfeec@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17.07.19 04:09, Zhenzhong Duan wrote:
> 
> On 2019/7/16 18:57, Juergen Gross wrote:
>> On 11.07.19 14:02, Zhenzhong Duan wrote:
>>> .. as "nopv" support needs it to be changeable at boot up stage.
>>>
>>> Checkpatch report warning, so move variable declarations from
>>> hypervisor.c to hypervisor.h
>>>
>>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>> Cc: Juergen Gross <jgross@suse.com>
>>> Cc: Stefano Stabellini <sstabellini@kernel.org>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Ingo Molnar <mingo@redhat.com>
>>> Cc: Borislav Petkov <bp@alien8.de>
>>> ---
>>>   arch/x86/include/asm/hypervisor.h | 8 ++++++++
>>>   arch/x86/kernel/cpu/hypervisor.c  | 8 --------
>>>   2 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/x86/include/asm/hypervisor.h 
>>> b/arch/x86/include/asm/hypervisor.h
>>> index f7b4c53..e41cbf2 100644
>>> --- a/arch/x86/include/asm/hypervisor.h
>>> +++ b/arch/x86/include/asm/hypervisor.h
>>> @@ -58,6 +58,14 @@ struct hypervisor_x86 {
>>>       bool ignore_nopv;
>>>   };
>>>   +extern const struct hypervisor_x86 x86_hyper_vmware;
>>> +extern const struct hypervisor_x86 x86_hyper_ms_hyperv;
>>> +extern const struct hypervisor_x86 x86_hyper_xen_pv;
>>> +extern const struct hypervisor_x86 x86_hyper_kvm;
>>> +extern const struct hypervisor_x86 x86_hyper_jailhouse;
>>> +extern const struct hypervisor_x86 x86_hyper_acrn;
>>> +extern struct hypervisor_x86 x86_hyper_xen_hvm;
>>
>> This should either stay const and be changed in patch 5, or you
>> should adapt its definition in arch/x86/xen/enlighten_hvm.c in
>> this patch.
> 
> Ok, thanks for your suggestion.
> 
> I'll choose 2nd opinion as I don't need to change descripton with that.

Just resend the last two modified patches then, please.


Juergen