Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp473470ybi; Tue, 16 Jul 2019 23:50:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+KBZhe0HkmVywCJmK3y5aAnA8rqPhuw986NuhL+TpXUFHAvoJSBMMTNSPEgeQZmzlG90c X-Received: by 2002:a63:c23:: with SMTP id b35mr6202200pgl.265.1563346204158; Tue, 16 Jul 2019 23:50:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563346204; cv=none; d=google.com; s=arc-20160816; b=qPC4m25TtaKj2nu/aJ7VX84R1wCFLcL1ON0QkTGj9ltJYfXvLBWaMAsZqdqSYjSa5A sAcuczxWr0SwOFZdRc+bd551PMM7ag9gQhWaHJUUb40AsqGQCmTJMk2nreL2H91HplH7 jzgkx6VuXwFz1YChxKD8wLgLRV41bmIcBoCFSsdrgdWqkaGvs2ksv2o0DN0aTeWd31hD ubWj5xW7mfncaBuBaJZJc6qwu8dpxF2FH3KZSDrGdCJcw3BMjzsb19MUV08YK1rZnl7V /G8007kclLyHIzFv7VM03WOs1dhN6z1N9bAA30fgbwCqdjZDsSvaKg10Rz9qv4uxsP3q KWtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=pc8SIHRE854jBH2RmlYS28AVA/XPhiR7UQcIcTJ8RRk=; b=ClIAr7CsRfENVJ4WCJhJJZtP6rX7LfjgdOwFn+5ng4fhG/k48pXUxUsHLxV2uuUPX+ 4jzuV1DXeC3jm5RnS8CQbRBTUeNYSCN603m86GTTL71hSYIAPLtUliiw2a4PJWunmIIn uz81IQgc2J+i2kHvwSBqRt8oljjVN/loUJmIcIbPijbfYzQ4WDae9Da/YQ0VGMpBFMNu +pMYuuoWcluvsglebC3cUGW2L5mCxIlIO7lhkUfmll9mlHgTJEVrJ8Sr+FQ9Bc9HvJ+A rnYgYeB8mGs9PJpiadyShtfdY5r4/YiByWYPoLZ60MgEVi2qyYhnsYfdl7DP/IZG4phE Vx6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r41si23244420pjb.11.2019.07.16.23.49.47; Tue, 16 Jul 2019 23:50:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727079AbfGQGtH (ORCPT + 99 others); Wed, 17 Jul 2019 02:49:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:58480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725912AbfGQGtH (ORCPT ); Wed, 17 Jul 2019 02:49:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E867EACAE; Wed, 17 Jul 2019 06:49:05 +0000 (UTC) Subject: Re: [PATCH v8 4/5] x86/paravirt: Remove const mark from x86_hyper_xen_hvm variable To: Joe Perches , Zhenzhong Duan , linux-kernel@vger.kernel.org Cc: bp@alien8.de, sstabellini@kernel.org, x86@kernel.org, tglx@linutronix.de, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com References: <1563251169-30740-1-git-send-email-zhenzhong.duan@oracle.com> <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> From: Juergen Gross Message-ID: Date: Wed, 17 Jul 2019 08:49:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <9791d12717bba784f24f35c29ddfaab9ccb78965.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.07.19 08:46, Joe Perches wrote: > On Tue, 2019-07-16 at 12:26 +0800, Zhenzhong Duan wrote: >> .. as "nopv" support needs it to be changeable at boot up stage. >> >> Checkpatch reports warning, so move variable declarations from >> hypervisor.c to hypervisor.h > [] >> diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c > [] >> @@ -259,7 +259,7 @@ static __init void xen_hvm_guest_late_init(void) >> #endif >> } >> >> -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = { >> +struct hypervisor_x86 x86_hyper_xen_hvm __initdata = { > > static? It is being referenced from arch/x86/kernel/cpu/hypervisor.c Juergen