Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Jul 2019 11:03:22 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paul.burton@mips.com>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: kernel: only use i8253 clocksource with periodic
 clockevent
Message-ID: <20190717090322.GA8585@alpha.franken.de>
References: <20190513114725.17823-1-tbogendoerfer@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190513114725.17823-1-tbogendoerfer@suse.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 13, 2019 at 01:47:25PM +0200, Thomas Bogendoerfer wrote:
> i8253 clocksource needs a free running timer. This could only
> be used, if i8253 clockevent is set up as periodic.
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
>  arch/mips/kernel/i8253.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/i8253.c b/arch/mips/kernel/i8253.c
> index 5f209f111e59..df7ddd246eaa 100644
> --- a/arch/mips/kernel/i8253.c
> +++ b/arch/mips/kernel/i8253.c
> @@ -32,7 +32,8 @@ void __init setup_pit_timer(void)
>  
>  static int __init init_pit_clocksource(void)
>  {
> -	if (num_possible_cpus() > 1) /* PIT does not scale! */
> +	if (num_possible_cpus() > 1 || /* PIT does not scale! */
> +	    !clockevent_state_periodic(&i8253_clockevent))
>  		return 0;
>  
>  	return clocksource_i8253_init();
> -- 
> 2.13.7

Paul,

can you take it into 5.3 ? This fixes a boot ang on mips/jazz and
is the same as x86 does for quite some time.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]