Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp928788ybi; Wed, 17 Jul 2019 07:05:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxa2ITBb9zwuAfK+sEdO7LArtpKW9DvF6/iCPNdTTslLmu2Mba0C69LE+FTVqaqyfHaiv9n X-Received: by 2002:a17:90a:2627:: with SMTP id l36mr45182228pje.71.1563372323994; Wed, 17 Jul 2019 07:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563372323; cv=none; d=google.com; s=arc-20160816; b=mpsouYB552o0dYM7kz04z5q/Yn+rZp3lvL3iLn0NyyOBlDL9EoQb3hBt/kQbmduW1j mA1UeevAYvAlLw1FOAHAcZqF0c3DiTGIJ1jK87znVSKJH4vuBZhpB2uSSANNu8f8h78Z Wyp5AG8aJUmYm3uxkNiCbCDS7QFTOvZXmJ5iCK1mlQ81/+dDPGw23g3MvvKPLrupR5Zw UiGyWV6AvthiJzvxWcOudZvk2XV0bZs/7IJ4w2ZlmMKtVMFhCxDt3k6uRCaZ1EI3saqH qd4ovZpS5ncoKR26+MbrevUIVcuJ60pcA+wEJD211xluWemRk23bM+NoWVdZ0aJTfsBk S8/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZznUD/3Doukl7awZznF628Vg6/9V6wzQqJQaI/2mctw=; b=0Ptab09lE9MfVtWAIdv28raAGkW12lkGvJTzYzH/TwgupRIudh+mkwbj+oX/klkWUg AgNlyakqMEniAwJSjTxuXtU7+AIElfkJB9+nQgNzcoaX+gYOTHgW+abKLITOaJiEcAEL o6WdgzQgQCt8uq1TpnhH0UW4+WG3jYlq1tsLbzL6RlDHTw5/1KC3iLMdEXc3Rbulx8du neduYqi07mG6jeGlD23k7tWxgfdHiOtWgwRH4rOpgV+8uB2eQtOf4RdJoiYpMtz5lzwe 8ZN+d6d8HxejJ3OdZFMqQOz99FqSWAMo2egZBnKJbUsUrgS4ufB/lOWuZyZnBFdtN8QR t4wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LXI3hn+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14si686095pgk.107.2019.07.17.07.05.06; Wed, 17 Jul 2019 07:05:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LXI3hn+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727248AbfGQOEP (ORCPT + 99 others); Wed, 17 Jul 2019 10:04:15 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41047 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbfGQOEP (ORCPT ); Wed, 17 Jul 2019 10:04:15 -0400 Received: by mail-wr1-f68.google.com with SMTP id c2so21769798wrm.8; Wed, 17 Jul 2019 07:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZznUD/3Doukl7awZznF628Vg6/9V6wzQqJQaI/2mctw=; b=LXI3hn+8n+V+6M8Q47325XdmRfkVNVfYLcd+e1GHj2TtXbZBiNh1fwFhgQoQrYcVZG UKIzpZnomSpzeOvsRwgz8S1YD2FNizYVlsW6noHnfRTSqQGamq10fCEyxHxg3loqYkrU nxdKO2LGO144u7GLuhmHbFHl/jheY/bhvflyOzi2Oj/dfONYGufdifrbhHjcZtSY6+hJ QiI7nZFkH71dQbVIoGhk6kV1sSVq06jXG94aB7IxUoi7qBC3Fte3Z+yV4XD3y3I8UaAX BnO4ZSLi3RApiAzB6KuD02WUdNIleg98kwZc+8APi+T5PEyKk+9P0SSh6atW8vthCjrw McJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZznUD/3Doukl7awZznF628Vg6/9V6wzQqJQaI/2mctw=; b=twJT7BntRAHIg4ckwhj5GeVyRwqrXZhS7LCOWw3KmmPfBK4nwTD8bCWmVdHKmc+pMI 27gWfh7wCeNHSDrI77HLUO4D6OpQtGuyz2oHrskNYxfw1EGvUXvMbCbGSdxUChz5T8DZ grjxgtoqs3LuNZg6dius+oT79JGoaG0luXCAN0QPR5Lu4yyxBD4lVWfi4Os81TVk/AaH Of98/RPHNuHbEgDXIItymX8MYitgH4i5OR4OnzlXfm7Q4NWfUyofTuabdmcM3QFRfSCH X9weNidDg3F3f3hZDL3fSnQSClIRJDK0StIgEoHU0BjglfRYaCD5WAi0jzRvI6aIIRVr oFSw== X-Gm-Message-State: APjAAAXle3HGaBJndhHR8Z99efmjsEMXBqARS+f6aZj0odT9DG35HjtH BJxlIPpoVO5H3fWginyX+25IaoRay6OSr4p9hh4= X-Received: by 2002:adf:f450:: with SMTP id f16mr12451048wrp.335.1563372252370; Wed, 17 Jul 2019 07:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20190702132353.18632-1-andradanciu1997@gmail.com> <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> <9e196ce51eac9ce9c327198c4a2911a8@www.akkea.ca> <1563292685.2676.12.camel@pengutronix.de> In-Reply-To: <1563292685.2676.12.camel@pengutronix.de> From: Daniel Baluta Date: Wed, 17 Jul 2019 17:04:01 +0300 Message-ID: Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes To: Lucas Stach Cc: Angus Ainslie , Mark Rutland , Devicetree List , Andra Danciu , Abel Vesa , Anson Huang , Carlo Caione , andrew.smirnov@gmail.com, Fabio Estevam , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , =?UTF-8?Q?Guido_G=C3=BCnther?= , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 16, 2019 at 6:58 PM Lucas Stach wrote: > > Hi Daniel, > > Am Mittwoch, den 03.07.2019, 16:25 +0300 schrieb Daniel Baluta: > > > On Wed, Jul 3, 2019 at 4:12 PM Angus Ainslie wrote: > > > > > > Hi Daniel, > > > > > > On 2019-07-03 07:10, Daniel Baluta wrote: > > > > > > > On Wed, Jul 3, 2019 at 4:01 PM Angus Ainslie wrote: > > > > > > > > > > Hi Andra, > > > > > > > > > > I tried this out on linux-next and I'm not able to record or play > > > > > sound. > > > > > > > > > > I also added the sai2 entry to test out our devkit and get a PCM > > > > > timeout > > > > > with that. > > > > > > > > Hi Angus, > > > > > > > > There are still lots of SAI patches that need to be upstream. Me and > > > > Andra > > > > will be working on that over this summer. > > > > > > > > > > > > > > On 2019-07-02 07:23, Andra Danciu wrote: > > > > > > SAI3 and SAI6 nodes are used to connect to an external codec. > > > > > > They have 1 Tx and 1 Rx dataline. > > > > > > > > > > > > > > > > > Cc: Daniel Baluta > > > > > > > > > > > Signed-off-by: Andra Danciu > > > > > > --- > > > > > > Changes since v2: > > > > > > - removed multiple new lines > > > > > > > > > > > > Changes since v1: > > > > > > - Added sai3 node because we need it to enable audio on pico-pi-8m > > > > > > - Added commit description > > > > > > > > > > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29 > > > > > > +++++++++++++++++++++++++++++ > > > > > > 1 file changed, 29 insertions(+) > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > > index d09b808eff87..736cf81b695e 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > > > > @@ -278,6 +278,20 @@ > > > > > > #size-cells = <1>; > > > > > > ranges = <0x30000000 0x30000000 0x400000>; > > > > > > > > > > > > > > > > > + sai6: sai@30030000 { > > > > > > + compatible = "fsl,imx8mq-sai", > > > > > > > > > > I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't > > > > > the registers at a different offset from "fsl,imx6sx-sai". > > > > > > > > Yes, you are right on this. We are trying to slowly push all our > > > > internal-tree > > > > patches to mainline. Obviously, with started with low hanging fruits, > > > > DTS > > > > nodes and small SAI fixes. > > > > > > > > Soon, we will start to send patches for SAI IP ipgrade for imx8. > > > > > > > > > > > > > > How is this supposed to work ? > > > > > > > > > > > > > For the moment it won't work unless we will upstream all our SAI > > > > internal patches. > > > > But we will get there hopefully this summer. > > > > > > > > > > Shouldn't a working driver be upstream before enabling it in the > > > devicetree ? > > > > I see your point here and maybe your suggestion is the ideal > > way to do things. > > > > Anyhow, I don't see a problem with adding the node in dts > > because CONFIG_FSL_SAI is not set in the default config. > > > > We try to speedup the upstreaming process giving the fact > > that SAI patches will go through audio maintainer's tree and > > the DTS patches will most likely go through Shawn's tree. > > I've also looked at adding audio support to one of the custom boards I > have here and was caught a bit off guard by the fact that the SAI > driver is totally broken for i.MX8M due to missing patches, as I > assumed the necessary bits are in place before the DT patches are > landed. It's certainly not how things are usually done. > > This also means the DT description of the SAI nodes is wrong, as they > are actually not compatible to the "fsl,imx6sx-sai". The register > layout is moved around, so there is no point in claiming any backwards > compat with the old SAI version. > > Do you have an ETA when the necessary patches for the i.MX8M SAI will > be available for test and review? No ETA for this. Sorry! We try to upstream it as soon as possible