Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp994606ybi; Wed, 17 Jul 2019 08:02:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqbNqyC9ErEa4xho8Tzs07rGN35D4Bw08uGJqi7gr0PEjPKoY/t8tJIGzFnGb5aozzdWpw X-Received: by 2002:a63:6ec6:: with SMTP id j189mr42599469pgc.168.1563375724464; Wed, 17 Jul 2019 08:02:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563375724; cv=none; d=google.com; s=arc-20160816; b=u1vfpuhdnA97AIlxCV9VA6NyKC1TEAFucB4qh0Jx2pJgbD8VZJYH0I0V1nR/YA2VJf Mx9ZJdCIBPbSX0+Wl3MAg7zseAdyH+earYtgcr61X6GW4LkRCFDMGLz13As7X0I+/1Bf vWx21ICOuwytRfrakzu5HzNALFXPyW5Dd9d8Yz3WMrwJebW3g6EsE+5Zy2uV5OK9DE0E oOLmKpT83iiHCo3RUXuzfmsQaDPnhoN1/VdldWLqmb1GnIv+524yIiuMsCkNhOeuEdIs iF88MwTBVC2AVnMlr7RMmpxd2FSoAXeporNDYqKCzoqa4f/hMriFPSEQc1DcSA90XKaq NT8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vb2hDr8pVB4vjeAsBCvCbr2ShBkp2oMLiBRzo3IXGcs=; b=cdJL9MGrUVSvpj2o7WaQdMIpygUGwkxQy6O/112xGXQIzyeY3vlja8MLR2pr/QNjbo AgDYbIKLOJN0Ds7avCvzX9FPgSnAVdNpix7xFMf1ZU3ERJQ4iJFAWL8NXOPbPB0Saxjv Ps3uTeRBRv2TYKY2XNVY3Tz2AKLyp2PP5PecPYq6GdXTsKHvDlHInMpbHvJaM20RqUep fWvGfjeE+OokaVksb6d81pgNaNB38zAbB7oEVyZAIffTMtoDfhc/jOEZ03UXgkYBdD5Q ozy7cUE4ww8RtWvd2iShbxh/RcasbIxIcEbCv1afGxdHzDvNmaW7xqp0+r95oNt6KMfv f24Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si22321770plp.229.2019.07.17.08.01.47; Wed, 17 Jul 2019 08:02:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727679AbfGQPAA (ORCPT + 99 others); Wed, 17 Jul 2019 11:00:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfGQPAA (ORCPT ); Wed, 17 Jul 2019 11:00:00 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4111308FEC0; Wed, 17 Jul 2019 14:59:59 +0000 (UTC) Received: from redhat.com (ovpn-125-71.rdu2.redhat.com [10.10.125.71]) by smtp.corp.redhat.com (Postfix) with SMTP id 7012E608A6; Wed, 17 Jul 2019 14:59:53 +0000 (UTC) Date: Wed, 17 Jul 2019 10:59:52 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , virtualization@lists.linux-foundation.org, Jason Wang , kvm@vger.kernel.org Subject: Re: [PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed Message-ID: <20190717105703-mutt-send-email-mst@kernel.org> References: <20190717113030.163499-1-sgarzare@redhat.com> <20190717113030.163499-6-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190717113030.163499-6-sgarzare@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 17 Jul 2019 14:59:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 17, 2019 at 01:30:30PM +0200, Stefano Garzarella wrote: > Since now we are able to split packets, we can avoid limiting > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > packet size. > > Signed-off-by: Stefano Garzarella OK so this is kind of like GSO where we are passing 64K packets to the vsock and then split at the low level. > --- > net/vmw_vsock/virtio_transport_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index 56fab3f03d0e..94cc0fa3e848 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -181,8 +181,8 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, > vvs = vsk->trans; > > /* we can send less than pkt_len bytes */ > - if (pkt_len > VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE) > - pkt_len = VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE; > + if (pkt_len > VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) > + pkt_len = VIRTIO_VSOCK_MAX_PKT_BUF_SIZE; > > /* virtio_transport_get_credit might return less than pkt_len credit */ > pkt_len = virtio_transport_get_credit(vvs, pkt_len); > -- > 2.20.1