Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1225094ybi;
        Wed, 17 Jul 2019 11:31:21 -0700 (PDT)
X-Google-Smtp-Source: APXvYqymtlQgYu5GQG8yhBG4de+FWJL+DDbUbJ4qPCKJfia1B+Xq163kMdECGWwxB0w7WPldzJ6X
X-Received: by 2002:a17:902:7407:: with SMTP id g7mr45442038pll.214.1563388281257;
        Wed, 17 Jul 2019 11:31:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1563388281; cv=none;
        d=google.com; s=arc-20160816;
        b=sfHn/WG/V1A2SE6A3xuAbquCC89LDtG5nvifKVQ/V/gcordJcdkwOWmUxSLlgZ2L7F
         57V6xQh033qcowJ3ppTriJqHQ0+Sveod1PCCVOrDwjbqMR7NsaacBndO7y0OsmBa3/Sh
         Ape5UtyHbv3XE/Kt2lnpBTsJuag5HaMLJIpcViXUDo4ztfFlDi/bCT5cJXYFwJgvE6PS
         xtTL9M+FtnRgarEom1YMOd62KzNeK/KQRE5V7MLpy01Ndz+WcDSREgDaBikTNhvqBxyz
         Yh/3cCK27rBa72xOJTEaKgTNZUJLIoTY1dw2Wyd9i2NKkuzVc8fGP2soOD/vABT+9PDE
         wtnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=SWBqWTLtRGRFAUZCgh3lTPUjJRJ6jQ100pAZoV0UM5g=;
        b=NzoK1c5ky9qVIBJdrlVYKVabFJRV2npqmcd8/uh3/xXOyz9M6HXfofaGsraB+ZbqqH
         TMnVfYknOWePZlabJDpmcUN6LpGIKG6yOYyk8RMAyfNkDnCm3UhJsBr9BJUgomGg0L+3
         FwmluLan3troVJLZmSZW1HDxTTazam+nWmQp7oO4ovaJAxl+Wi9CvsxaOfAUeUEHWOj5
         648SM+45EDUwaeSAqffQHuZ5IoaTLgLLim2R1bolCUlSkP9mm+GAQnzB53bcHvZBL164
         YBVe0Ya11Vbrk1pd+ujnTMp0ogax7DI5leERxTYB1J7hasz0atgvQCdCkyz+YP+k+R70
         ZPlA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=CV5RjjFY;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t19si25222429pfe.94.2019.07.17.11.31.05;
        Wed, 17 Jul 2019 11:31:21 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=CV5RjjFY;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727377AbfGQRu0 (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Wed, 17 Jul 2019 13:50:26 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:12191 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727255AbfGQRu0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 Jul 2019 13:50:26 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d2f5fdf0000>; Wed, 17 Jul 2019 10:50:23 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 17 Jul 2019 10:50:25 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 17 Jul 2019 10:50:25 -0700
Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Jul
 2019 17:50:21 +0000
Subject: Re: [PATCH 1/3] mm: document zone device struct page reserved fields
To:     Christoph Hellwig <hch@lst.de>, John Hubbard <jhubbard@nvidia.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <willy@infradead.org>, Vlastimil Babka <vbabka@suse.cz>,
        Christoph Lameter <cl@linux.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Pekka Enberg <penberg@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
References: <20190717001446.12351-1-rcampbell@nvidia.com>
 <20190717001446.12351-2-rcampbell@nvidia.com>
 <26a47482-c736-22c4-c21b-eb5f82186363@nvidia.com>
 <20190717042233.GA4529@lst.de>
 <ae3936eb-2c08-c4a4-f670-10f25c7e0ed8@nvidia.com>
 <20190717043824.GA4755@lst.de>
X-Nvconfidentiality: public
From:   Ralph Campbell <rcampbell@nvidia.com>
Message-ID: <4295112b-e5ff-f9ad-defc-597ad3bc49a1@nvidia.com>
Date:   Wed, 17 Jul 2019 10:50:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190717043824.GA4755@lst.de>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1563385823; bh=SWBqWTLtRGRFAUZCgh3lTPUjJRJ6jQ100pAZoV0UM5g=;
        h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=CV5RjjFYrtxJBPx50YvgVwuu37aXkSWSWDX7gZc9Perx7pREk/ltNltuoF01N12nF
         fbcGNahPv9Pu7cj2VWx7kgYouKXYLs74/GvanmWlQgzAEpDd+r92oWoAmxifsQSOjY
         IZCfGm6yu8dITo783GAtU7Q+sH2EPk3XJuBReBiHhao9nODGOnDHYbAxPp59+502lb
         1vSZkgb7BwefFsx24B8sNYTUZW17BtBCGEjl7ecTuX83NvLUYsDv8AWDDqHZBPf1J2
         lV2g4EFQ6YMntYjOwT54R0Kw2q3EvgtT+HYCrx1u69MVIzVv+IMtetkOAJZcos5+bY
         UxIthrioLOHeQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/16/19 9:38 PM, Christoph Hellwig wrote:
> On Tue, Jul 16, 2019 at 09:31:33PM -0700, John Hubbard wrote:
>> OK, so just delete all the _zd_pad_* fields? Works for me. It's misleading to
>> calling something padding, if it's actually unavailable because it's used
>> in the other union, so deleting would be even better than commenting.
>>
>> In that case, it would still be nice to have this new snippet, right?:
> 
> I hope willy can chime in a bit on his thoughts about how the union in
> struct page should look like.  The padding at the end of the sub-structs
> certainly looks pointless, and other places don't use it either.  But if
> we are using the other fields it almost seems to me like we only want to
> union the lru field in the first sub-struct instead of overlaying most
> of it.
>

I like this approach.
I'll work on an updated patch that makes "struct list_head lru" part
of a union with the ZONE_DEVICE struct without the padding and update
the comments and change log.

I will also wait a day or two for others to add their comments.