Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1613243ybi; Wed, 17 Jul 2019 18:45:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUIua+gGcR4vteeRMPQ5c3OD5S4EYXzrKJ5Xo94gQ/CNxOlCbupDB/zTVnw9gyxcLaszcA X-Received: by 2002:a63:ff65:: with SMTP id s37mr3881098pgk.102.1563414310669; Wed, 17 Jul 2019 18:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563414310; cv=none; d=google.com; s=arc-20160816; b=VueL8oDMwymWkk1H+PTTkwHad9Dgnq16WdHPmENC78IGhAZI3+qMod4SmIED3nK4ma D07d019H2dwOX1aMthHFR7UqmDhILKgmyd1WQSMIw/guRmuAxx7vpCPpA+J1hGwrz8TW yrKjEMQY/aJNDSffoWwLkJNesudPop1WGDvyEcJNLlf48yJ6GBejeJliOI0bkCRBq6Np FSf14sjA5OvdKqGDO6d0OkFXkUuTFSPc2qWGgkwdYtBV1i5EHdGxD/7TZWKIyPCi/U06 44T8owf7mFPIDDADeIz+fRSWMVhQPTTsgs8glXWPjGuCX+BNQ1UKtl3V5z3WrH5I/GO/ 2edg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LK0yQAlxf5/baC7cw+k9tZObT+cdczBCy7jBTPwz5j8=; b=M8J3mT4GR3PLqCTmNqs3YhhgLnfxPu5iwlRmunh5Lec2kT+a2StvNryLkW7k+Y43/x Uh3sByRWPBbyaDafks9sbYHrlmUFxsvxOTZ9iatjGqdE3mk82KExLS82GvP8GLP2DbsJ s3Vhw8sSUfp5x48Jii7B4zKYpFmGslccLRWisLutbCwq5nghNWNqN6au6LBhOFzASy6B lQ9HA3GWrr5cii2m7/dMudXZqIw5ZHJdS5wPE2IkKR5IYP2Ya4Ipe+9aStW6HFeA3sR9 16OVi93E02T3dHT82VD0qHmn1KhRxGKGvzcw+v4jYCE6Anw0UtOfN6iCC/I+mKbxy76U oBkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l28si4141819pgm.311.2019.07.17.18.44.54; Wed, 17 Jul 2019 18:45:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733109AbfGRBoR (ORCPT + 99 others); Wed, 17 Jul 2019 21:44:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54382 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731647AbfGRBoR (ORCPT ); Wed, 17 Jul 2019 21:44:17 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D047130821AE; Thu, 18 Jul 2019 01:44:16 +0000 (UTC) Received: from whitewolf.redhat.com (ovpn-120-112.rdu2.redhat.com [10.10.120.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5342F19C67; Thu, 18 Jul 2019 01:44:13 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org Cc: Juston Li , Imre Deak , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Harry Wentland , Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH 04/26] drm/print: Add drm_err_printer() Date: Wed, 17 Jul 2019 21:42:27 -0400 Message-Id: <20190718014329.8107-5-lyude@redhat.com> In-Reply-To: <20190718014329.8107-1-lyude@redhat.com> References: <20190718014329.8107-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 18 Jul 2019 01:44:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A simple convienence function that returns a drm_printer which prints using pr_err() Cc: Juston Li Cc: Imre Deak Cc: Ville Syrjälä Cc: Harry Wentland Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_print.c | 6 ++++++ include/drm/drm_print.h | 17 +++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index a17c8a14dba4..6112be358769 100644 --- a/drivers/gpu/drm/drm_print.c +++ b/drivers/gpu/drm/drm_print.c @@ -147,6 +147,12 @@ void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf) } EXPORT_SYMBOL(__drm_printfn_debug); +void __drm_printfn_err(struct drm_printer *p, struct va_format *vaf) +{ + pr_err("%s %pV", p->prefix, vaf); +} +EXPORT_SYMBOL(__drm_printfn_err); + /** * drm_puts - print a const string to a &drm_printer stream * @p: the &drm printer diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index a5d6f2f3e430..112165d3195d 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -83,6 +83,7 @@ void __drm_printfn_seq_file(struct drm_printer *p, struct va_format *vaf); void __drm_puts_seq_file(struct drm_printer *p, const char *str); void __drm_printfn_info(struct drm_printer *p, struct va_format *vaf); void __drm_printfn_debug(struct drm_printer *p, struct va_format *vaf); +void __drm_printfn_err(struct drm_printer *p, struct va_format *vaf); __printf(2, 3) void drm_printf(struct drm_printer *p, const char *f, ...); @@ -227,6 +228,22 @@ static inline struct drm_printer drm_debug_printer(const char *prefix) return p; } +/** + * drm_err_printer - construct a &drm_printer that outputs to pr_err() + * @prefix: debug output prefix + * + * RETURNS: + * The &drm_printer object + */ +static inline struct drm_printer drm_err_printer(const char *prefix) +{ + struct drm_printer p = { + .printfn = __drm_printfn_err, + .prefix = prefix + }; + return p; +} + /* * The following categories are defined: * -- 2.21.0