Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1687578ybi; Wed, 17 Jul 2019 20:08:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzG5n0km46QXnRBciM+Yl0BA3R9bNb5RPUvn6pZ1LxbhThLksUL0H+X/I0A3OqF8d5PuGlG X-Received: by 2002:a17:90b:d8a:: with SMTP id bg10mr48523808pjb.92.1563419326749; Wed, 17 Jul 2019 20:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563419326; cv=none; d=google.com; s=arc-20160816; b=UCp5dzyTmDMyoJ7vQVOLTjtjUhcsdjOLq8r6VL+W7RRSD76hkDhn2qOdSnPKOZmPvf QKYKP25XmPH7NxnuL3UgTLlavb9cSUsB9GEs8GePpHq5Z25iTBnsp3lMucNUHJeyd51l 0zM87nD8wuSDFEEATNk2J4bGu/i3egTPJQrQujqx9bDgrXfsR0DW6MIs5IGs4deme+ys 5cMzFEe7JgrfcX30v3UbWcdczR+w6KYUlGVedvwESW3lxWTC3/CSRlHetwd9OOq1mk1w 7DW0oXzNjE5BHownvxvfYWxSyj7lZEMY4aJnkgOcUbPSbYNJN5yCaRKgULm9YNbL7zoP 1CYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PYo546EDzUvV9iKiVvwanQJuh+JGl1nMA9668CaTkqc=; b=i2MlQJVLoEy727fE96V2lr2MSaqPg1CBbqx1hs053vUKBbVUdGfI1wOhQqKdBK5euv RvJ4e+sk6QNfZvHBWHykg8jarpkTKuXUR2T8T3U4l7CvWezXvUq5Pw9918lVFgdzyRfj Egc72AfricCm1MgK6vLJQemXRufxz+9KQJGXEr32HrIWtAuOZTpr/DyWF9p+glM0fhoS S3hPtxghRKCOwqrF0QDU9lbA5RngqTvw7pPXXSlPgugfxR3wUEgN9pjXjGfNxETLE8DI O8OQFnjrAhQHOIxyVpIcojIu61hZLM7OORODVtygEzi4+gJU6gZzmW2KheQhM5SMTQSF 0N0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2X+wDv9d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si1295069pfl.261.2019.07.17.20.08.30; Wed, 17 Jul 2019 20:08:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2X+wDv9d; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390426AbfGRDHX (ORCPT + 99 others); Wed, 17 Jul 2019 23:07:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:38856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390400AbfGRDHT (ORCPT ); Wed, 17 Jul 2019 23:07:19 -0400 Received: from localhost (115.42.148.210.bf.2iij.net [210.148.42.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5856121849; Thu, 18 Jul 2019 03:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563419238; bh=ej18VNWinyrKMWEU+mxAT/c7G+nIfeAfdwON843YUsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2X+wDv9dG9o/fgndBvQBJGm9ELRKxH6CcTPEoy1IMU+nWPbLdHS4RN69Rp71AmuYx Rt+1qNpCHMrC7lJRjlHaY3iTyH5jGmf96rsZV81x2iaGFF7irpBxHFYrsufmZfctpr ht/TjxUkxQJ7nlrlCQP38E/LN2alkILmV8tsgkuI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Ard Biesheuvel , Sasha Levin Subject: [PATCH 4.19 09/47] efi/bgrt: Drop BGRT status field reserved bits check Date: Thu, 18 Jul 2019 12:01:23 +0900 Message-Id: <20190718030049.364224408@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190718030045.780672747@linuxfoundation.org> References: <20190718030045.780672747@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit a483fcab38b43fb34a7f12ab1daadd3907f150e2 ] Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer reserved. These bits are now used to indicate if the image needs to be rotated before being displayed. The first device using these bits has now shown up (the GPD MicroPC) and the reserved bits check causes us to reject the valid BGRT table on this device. Rather then changing the reserved bits check, allowing only the 2 new bits, instead just completely remove it so that we do not end up with a similar problem when more bits are added in the future. Signed-off-by: Hans de Goede Signed-off-by: Ard Biesheuvel Signed-off-by: Sasha Levin --- drivers/firmware/efi/efi-bgrt.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c index b22ccfb0c991..2bf4d31f4967 100644 --- a/drivers/firmware/efi/efi-bgrt.c +++ b/drivers/firmware/efi/efi-bgrt.c @@ -50,11 +50,6 @@ void __init efi_bgrt_init(struct acpi_table_header *table) bgrt->version); goto out; } - if (bgrt->status & 0xfe) { - pr_notice("Ignoring BGRT: reserved status bits are non-zero %u\n", - bgrt->status); - goto out; - } if (bgrt->image_type != 0) { pr_notice("Ignoring BGRT: invalid image type %u (expected 0)\n", bgrt->image_type); -- 2.20.1