Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1709517ybi; Wed, 17 Jul 2019 20:32:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZbGZga6KEbNj/IkuWhTYHEt3rmI1TSQWcMqzuxN9qr6L3abuyoXb2EgYo7+4RV31k2LJV X-Received: by 2002:a17:902:724:: with SMTP id 33mr46447809pli.49.1563420739586; Wed, 17 Jul 2019 20:32:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563420739; cv=none; d=google.com; s=arc-20160816; b=gPdK9tyQnC6CGrmkp1fo5NMra5ad+RKpNGsenKAEQ0h5mTvtD9v+ETqRVhopmm53pN oqTg8WnXhp0HYaCneXQRUxLv5Igvi2fMWw6y//G7Q7DLXRT1KcHSihFpH6mMiWYOtxVK qnSEFI9xntqQ+lUFBQUiDiMtm21HICWftQ4cC8bFE2X3IhQvSNnwVNavaxHmgyqTLwa7 Aj/ioLadiNU/9idbUtAg91G9BHGOFOdooa6TdSWMBof4pvKrNYVHqEk4YVJiBklDbRD8 O8yj5M0VpWz2pgbxT0oF+gsZUfZpRU8O71QuJ3pzsU2UnqoXKlR2tmywCNiANAFSO4GF OREw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JIZLCaXssARCE12KPqhYRg7IiEzi8/C+WG2l+D6FIys=; b=WkaBbQRFqZSMuZaXkXaC4Ug7DxFgo3Pwb1/gHVVtiGxdlQ1vtxRXbvn+tOm4fJIxry 35ptuCKqhdSqyTdpJhBF18sdVATxgmzNIW2UaDyRn3ZkKUjvLkTYopS8fSCsjrhtz9oh Hf62kCeb1qD4y1aLWOYCEOdFk2qiroaZo76kLsj3BfmOszg+YDv/L+c9/FCCL66JA0aZ 86ti0GKYqHFzFJZZJ4Ab7O3a8djEKem9IuBU8mA7Cu9cQIWYfrmZxuCSCgjAMYRDWpIC xk2htZdJNxl03Akc1774ifSGiWlESfKUhwO3ugH44dLdqVH1l8AxkUSYdyfMIZMG9E00 7Y5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10si1490714pff.277.2019.07.17.20.32.02; Wed, 17 Jul 2019 20:32:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389503AbfGRDbo (ORCPT + 99 others); Wed, 17 Jul 2019 23:31:44 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:38132 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387728AbfGRDbo (ORCPT ); Wed, 17 Jul 2019 23:31:44 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hnx8l-0005Y6-TS; Thu, 18 Jul 2019 11:31:31 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hnx8l-00052C-PB; Thu, 18 Jul 2019 11:31:31 +0800 Date: Thu, 18 Jul 2019 11:31:31 +0800 From: Herbert Xu To: Daniel Jordan Cc: Steffen Klassert , Andrea Parri , Boqun Feng , "Paul E . McKenney" , Peter Zijlstra , linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Mathias Krause Subject: Re: [PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Message-ID: <20190718033131.4m4ypbq7tiucqcsl@gondor.apana.org.au> References: <20190716163253.24377-1-daniel.m.jordan@oracle.com> <20190717111147.t776zlyhdqyl5dhc@gondor.apana.org.au> <20190717183227.b3hqphukkndqumhw@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190717183227.b3hqphukkndqumhw@ca-dmjordan1.us.oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 17, 2019 at 02:32:27PM -0400, Daniel Jordan wrote: > > We'll crash when cpumask_next_wrap returns nr_cpumask_bits and later try to get > the corresponding per-cpu queue. The whole point of cpumask_next_wrap is to wrap around to the beginning when it hits nr_cpumask_bits. So it cannot return nr_cpumask_bits. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt