Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <9eda0e29f524275a217411ea81352271b782baa4.camel@perches.com>
Subject: Re: [PATCH] KVM: x86/vPMU: refine kvm_pmu err msg when event
 creation failed
From:   Joe Perches <joe@perches.com>
To:     Like Xu <like.xu@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Avi Kivity <avi@scylladb.com>
Cc:     kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
        like.xu@linux.inetl.com, linux-kernel@vger.kernel.org
Date:   Wed, 17 Jul 2019 22:18:46 -0700
In-Reply-To: <20190718044914.35631-1-like.xu@linux.intel.com>
References: <20190718044914.35631-1-like.xu@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-07-18 at 12:49 +0800, Like Xu wrote:
> If a perf_event creation fails due to any reason of the host perf
> subsystem, it has no chance to log the corresponding event for guest
> which may cause abnormal sampling data in guest result. In debug mode,
> this message helps to understand the state of vPMC and we should not
> limit the number of occurrences.
[]
> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
[]
> @@ -131,8 +131,8 @@ static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type,
>  						 intr ? kvm_perf_overflow_intr :
>  						 kvm_perf_overflow, pmc);
>  	if (IS_ERR(event)) {
> -		printk_once("kvm_pmu: event creation failed %ld\n",
> -			    PTR_ERR(event));
> +		pr_debug("kvm_pmu: event creation failed %ld\n for pmc->idx = %d",
> +			    PTR_ERR(event), pmc->idx);

Perhaps this was written as printk_once to avoid
spamming the log with repeated messages.

Maybe this should use pr_debug_ratelimited.
(and it should also have a \n termination like:)

		pr_debug_ratelimited("kvm_pmu: event creation failed %ld for pmc->idx = %d\n",
				     PTR_ERR(event), pmc->idx);

Perhaps Avi Kivity remembers why he wrote it this way.
https://lore.kernel.org/kvm/1305129333-7456-6-git-send-email-avi@redhat.com/