Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1949476ybi; Thu, 18 Jul 2019 00:54:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+eLsiiN1WZJkmnCMPJLrVYpdp83YVLjNaQYWTA1dXLcN+uDJt7rQdb9t9lwDtm5Lbg8iA X-Received: by 2002:a17:902:7687:: with SMTP id m7mr49253877pll.310.1563436440711; Thu, 18 Jul 2019 00:54:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563436440; cv=none; d=google.com; s=arc-20160816; b=06xyShPS0N32CulXCWz3bw+/62a1emY3EwfxFSC484yjqJx1xWGWwPJfR9NFrOGf8R 2yaYbiaGcBqMiqa6HyUT/evcUitgDhIpa6P/u+vwT+KZ8WxF0djTs6xl6GJNpZd7aT3L iYgSEArrTdR5FqJMIwj6Dalf46cAOlYU0CMW0A03SkyzEgjR0mMwfy95xtoZy2uYvLAR 7wabixizKY2sjstv4OXQsjiwSBGhDZj0XHSNp5lP4XunyOk5iff50sJ9gi4Y2vMg64Ps I9sBxHsHr6B9mNkufASyrZGy4jFPioqmNUCDkOPSLyHwjo50DsbOfazoLoH8N75tLyl1 NtqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rq+59r0RojlnTnigSljktyDPpoq1gf7r9wfF77O5XwQ=; b=w2l/VKEesVN4YXS8vrcU6BauS60FqUGMUHIRNLrLKpj+xbBJI9tj8irvHm3xBI1gLR V2OOsC4CTO2R8Kk4ppKGT+o22jxUEVNqMTpNrHuxaH7VwBK0692mXvWm1Mbwnf1Pi2sk zUWNccCAlZ+fyROCMLq9Ml0PpH2uGKFyundqEjPYf0f1PowF9VaKzqUXsXbMsQBoFkLd etqJSPLXBpCRhOTI8m7zHMyZXuVDJMwaTcqjcdA+XPp+B8B+B94pfOSGd4w9LO7DyZTp J4UwfeV2jl+EooLD2PzbjAhjKE+2Iyy1GIHVCi1yZrYAEIPJ4SrMxloun2c3MUXKOE0Y TQ2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si944649pgw.454.2019.07.18.00.53.44; Thu, 18 Jul 2019 00:54:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389426AbfGRHww (ORCPT + 99 others); Thu, 18 Jul 2019 03:52:52 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35852 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbfGRHww (ORCPT ); Thu, 18 Jul 2019 03:52:52 -0400 Received: by mail-wr1-f65.google.com with SMTP id n4so27585630wrs.3 for ; Thu, 18 Jul 2019 00:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rq+59r0RojlnTnigSljktyDPpoq1gf7r9wfF77O5XwQ=; b=YlJIvFdK9RTzavLgKitSLvx0MPcv4INNmhWl0fLeGaFgw2dAhRImSVpgs7gnqKdJiv FL4YHSnGiDeKlQ4EveDW8uAxRHKXLIghwXCe2kmBOR+yM+2cn9jdLRlAbRrThwxsM9Rg 8NlSin/0tylm9yYoXDpZYtoYzBhd/hBHuWEiVY2yhTTcR/4sDcu3iE0RbGan7okVB/C1 2s/l+lxdVviru/H4psOV/EVEmuToKTJOqJvnT0+R0q8Cq9Vi82y9dRLckE5xKDaLobRG t/yu0ayca9NAmC0P5CxGcFujGMGEzv7Jsbve8hQu4tJYleFHGjskievIyYCvM9MUstVD RR+Q== X-Gm-Message-State: APjAAAVzcYd1VRdHa+wC9BUbLTvC3b275mKji3CDLy47QLAW1m1+tKje G5U2JwUwIldNt9Ae50qP5PbLnQ== X-Received: by 2002:adf:e6c5:: with SMTP id y5mr50042800wrm.235.1563436370235; Thu, 18 Jul 2019 00:52:50 -0700 (PDT) Received: from steredhat ([5.170.38.133]) by smtp.gmail.com with ESMTPSA id 91sm54324185wrp.3.2019.07.18.00.52.48 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 00:52:49 -0700 (PDT) Date: Thu, 18 Jul 2019 09:52:41 +0200 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , virtualization@lists.linux-foundation.org, Jason Wang , kvm@vger.kernel.org Subject: Re: [PATCH v4 5/5] vsock/virtio: change the maximum packet size allowed Message-ID: References: <20190717113030.163499-1-sgarzare@redhat.com> <20190717113030.163499-6-sgarzare@redhat.com> <20190717105703-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190717105703-mutt-send-email-mst@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 17, 2019 at 5:00 PM Michael S. Tsirkin wrote: > > On Wed, Jul 17, 2019 at 01:30:30PM +0200, Stefano Garzarella wrote: > > Since now we are able to split packets, we can avoid limiting > > their sizes to VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE. > > Instead, we can use VIRTIO_VSOCK_MAX_PKT_BUF_SIZE as the max > > packet size. > > > > Signed-off-by: Stefano Garzarella > > > OK so this is kind of like GSO where we are passing > 64K packets to the vsock and then split at the > low level. Exactly, something like that in the Host->Guest path, instead in the Guest->Host we use the entire 64K packet. Thanks, Stefano