Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2018159ybi; Thu, 18 Jul 2019 02:05:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7V+E1WazY0h6kg/bk8ebZD7Kr8k3XWQdtcP5URQ7sdi51BFIci4WFR3k0X6JeqAgjPZ5W X-Received: by 2002:a63:4823:: with SMTP id v35mr19143913pga.138.1563440748236; Thu, 18 Jul 2019 02:05:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1563440748; cv=pass; d=google.com; s=arc-20160816; b=govoRVs2IpcObMgbW00m9jAB0ehYaAQFOw+5bYeMTnO9i/BsAhisJYFvH3marHY2Lp LtEZ72Y8qcDBX3DxRz7veS3TlbdDRDAufWHzTHfrgseC/fVGeflJGuSVCAot5aM8p4J1 KkGsbyCrIF4gGAMoennQ1+mqAbF+XGmzy/GI/nNEeQCWVgNy871E95D+PqYDPyYRVw19 sz7jMm/jSnS4FDNDwDnhZOE/wsmzWKoTLDO/fwt03PbGuk+GjCuZ/rm3Lus8m5ZaQsSR UnYfO032UVvd9hv9O0o2hfo0K/vI+JJW4+Y9EeW4W/FHYhPaeNWBMcUAncyvhgaL/X2F N3ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=5uLXKJYrLvfHg3G7lZuDe0a46kS1kUy/19CYoEhFZ8o=; b=Pj4GP0Jh0zz/l7nrntq0QXdoNdVGR3zcVjodCi2k0Wmls60IGB8gjQxKF17NZUiE5N qvwISIRJYwetJmX43A/lBGV7IvcTmYI+ULDFMvKHx/X6QOkCz6etL2G4Yq0ob0CR2Hvn MBQp7v28qYodePrBIbeJevmHtObErq/MkV7bBbBZXQr29Hwf6anrwvH2rZPZEUfz9AUV xr3DsRClMYhsi5cSwsTJ6Mec5B0L+jeIXnaPlxcw8Nj1DXVk3peE/OFRtoV+MMO8wyLq zsA016JDSHslHhZHzQUMVTYkQDF3BJI+/3pPgYHSasF11YJKwxaa4wEH1mpFP3kvIUJu GfCw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@toradex.com header.s=selector1 header.b=q8ZRS0jd; arc=pass (i=1 spf=pass spfdomain=toradex.com dkim=pass dkdomain=toradex.com dmarc=pass fromdomain=toradex.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=toradex.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n63si1626068pjb.36.2019.07.18.02.05.32; Thu, 18 Jul 2019 02:05:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toradex.com header.s=selector1 header.b=q8ZRS0jd; arc=pass (i=1 spf=pass spfdomain=toradex.com dkim=pass dkdomain=toradex.com dmarc=pass fromdomain=toradex.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=toradex.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389739AbfGRJDC (ORCPT + 99 others); Thu, 18 Jul 2019 05:03:02 -0400 Received: from mail-eopbgr150109.outbound.protection.outlook.com ([40.107.15.109]:61477 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389688AbfGRJDA (ORCPT ); Thu, 18 Jul 2019 05:03:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lYZCc4pgnE1rJWTMDhqhe/0YzEkDME8mJASJdq0HrnrL6isKOUXARCDA6uG6thvFmRASz+6ew+0f6spF2PaBCPZsVaGimK+s/cW0JnrjSV7HtJLP1kdZY5wzw9O+q7MsIcWS8Yc0u4wU6w/46RwiHYhpIXas0+VFw53O87E0jhcqNuYmtdjsPQa9/51yLQwcS4ELZt9+FPRaxxLHBXvp0ZRwDxFBwZaAERpSWCNLpdNeIp/KqSWKGcrsqgDQVZx4P1dtSe4fxjNdRPtrDs8M2Phye2dxZYLcyfZ7HoHeCG+5Qi0xAB89fD9ED+VNbbe8/z+15ajqxRfLVpzYWxZzyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uLXKJYrLvfHg3G7lZuDe0a46kS1kUy/19CYoEhFZ8o=; b=djbttD9JIf7mYEpn1d8/SobCzlvVyv3lmxBhJL/grHJ1qRNhCGtrpbARd9OtFWFlqm1aAJzx2JE9ss3GtuVW7QzHOB4XtTPL1mEJtzorOv5t1g5DYi6GjEnCw//3hG2MIqOOLEv2GiVZ0UdXNK0Vz6e70tHbm2WQ2xJyFlvTVECbHpTIkfEtzfrYkhY15gzeyeJ2nPcJIYthepKBqvx94GnGoynqCBo+qAazjkdcRRaGuDLQUxCekkgsmOrm0t84ILkn6Qxnr8QGIcKUm0Xp7vBSQX6DZ85HvwGOcRIXbijrrI9AVw6t7TCMsVZQBfK9QVQ/2fl08O4He2GkjxQ1Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=toradex.com;dmarc=pass action=none header.from=toradex.com;dkim=pass header.d=toradex.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uLXKJYrLvfHg3G7lZuDe0a46kS1kUy/19CYoEhFZ8o=; b=q8ZRS0jdoMecmlBF7Y1puxynwCSafg0TBSl1nLybxE6kzOif//Bep0fi5e5MUm3MoGU8FerwL94nN5G81MnOqPs1TpV6Phb91mY87kqfOTx0/Ews+S3oJpiDjsLSJxLz96v6ZJb+6VfOsUtvXSh9nagFjnRCobBvYZ89GX3A7FE= Received: from AM6PR05MB6535.eurprd05.prod.outlook.com (20.179.18.16) by AM6PR05MB5013.eurprd05.prod.outlook.com (20.177.35.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Thu, 18 Jul 2019 09:02:54 +0000 Received: from AM6PR05MB6535.eurprd05.prod.outlook.com ([fe80::c860:b386:22a:8ec9]) by AM6PR05MB6535.eurprd05.prod.outlook.com ([fe80::c860:b386:22a:8ec9%6]) with mapi id 15.20.2094.011; Thu, 18 Jul 2019 09:02:54 +0000 From: Oleksandr Suvorov To: Fabio Estevam CC: "linux-kernel@vger.kernel.org" , Igor Opaniuk , Marcel Ziswiler , "alsa-devel@alsa-project.org" , Oleksandr Suvorov , Jaroslav Kysela , Mark Brown , Takashi Iwai , Liam Girdwood Subject: [PATCH v5 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe Thread-Topic: [PATCH v5 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe Thread-Index: AQHVPUeU/o3Hdj/K5UqwPeiB1Nflkw== Date: Thu, 18 Jul 2019 09:02:52 +0000 Message-ID: <20190718090240.18432-6-oleksandr.suvorov@toradex.com> References: <20190718090240.18432-1-oleksandr.suvorov@toradex.com> In-Reply-To: <20190718090240.18432-1-oleksandr.suvorov@toradex.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR0102CA0001.eurprd01.prod.exchangelabs.com (2603:10a6:208:14::14) To AM6PR05MB6535.eurprd05.prod.outlook.com (2603:10a6:20b:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=oleksandr.suvorov@toradex.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [194.105.145.90] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b14652e-3b4f-4b88-eb28-08d70b5eb74a x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:AM6PR05MB5013; x-ms-traffictypediagnostic: AM6PR05MB5013: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(39850400004)(346002)(366004)(376002)(396003)(136003)(199004)(189003)(2616005)(99286004)(68736007)(476003)(446003)(50226002)(11346002)(486006)(86362001)(8936002)(81166006)(76176011)(81156014)(26005)(14454004)(4326008)(186003)(386003)(6506007)(316002)(102836004)(6916009)(54906003)(52116002)(36756003)(6486002)(6436002)(71190400001)(71200400001)(6512007)(25786009)(14444005)(66066001)(256004)(66946007)(64756008)(66476007)(66556008)(66446008)(1076003)(1411001)(5660300002)(8676002)(478600001)(7736002)(44832011)(6116002)(3846002)(305945005)(53936002)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM6PR05MB5013;H:AM6PR05MB6535.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: toradex.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uJZ8wbCj5V1wQSomMxF4TN9ZL4E6y3WcyyJGQLp2qPIG+lfweDzCq9Ud9D2igmOLbFLkLJSHNfaN0JxpTVKLJW5dAPhBvui2mr8HH7trn4Dvz8aMT2PkY3Y4BGuEruvVKqja2IxwP74KkB+u/XtmnOGdOeUxQZLmqzeRjUB0ZeuZF5XQDQhGqQy79B4fzXRXr6KLNCr5ItLZyq4G029OSlahdRn+V1pHkmPJ3/C3PG8dAaKRGqsEU0WCwdpz03vHOR0JQXmCSh6P6Fxphh65KRiXsp9grWpng+yTqBmLCVakKU1mr03aUMZFaytSdALCK4cZ+JdxPY6ztqJqDmp4hAtkNTOLleZnUPhMicFc/mV288OJqZpgkudkEcpv/j0ZViGIENE41h4s3sonbPpVdiyARaiTduAWblcyWFq6GvI= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b14652e-3b4f-4b88-eb28-08d70b5eb74a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 09:02:52.7115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oleksandr.suvorov@toradex.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 0123d9cfcb473..31d546abde717 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1443,6 +1443,7 @@ static int sgtl5000_probe(struct snd_soc_component *c= omponent) int ret; u16 reg; struct sgtl5000_priv *sgtl5000 =3D snd_soc_component_get_drvdata(componen= t); + unsigned int zcd_mask =3D SGTL5000_HP_ZCD_EN | SGTL5000_ADC_ZCD_EN; =20 /* power up sgtl5000 */ ret =3D sgtl5000_set_power_regs(component); @@ -1470,9 +1471,8 @@ static int sgtl5000_probe(struct snd_soc_component *c= omponent) 0x1f); snd_soc_component_write(component, SGTL5000_CHIP_PAD_STRENGTH, reg); =20 - snd_soc_component_write(component, SGTL5000_CHIP_ANA_CTRL, - SGTL5000_HP_ZCD_EN | - SGTL5000_ADC_ZCD_EN); + snd_soc_component_update_bits(component, SGTL5000_CHIP_ANA_CTRL, + zcd_mask, zcd_mask); =20 snd_soc_component_update_bits(component, SGTL5000_CHIP_MIC_CTRL, SGTL5000_BIAS_R_MASK, --=20 2.20.1