Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2027271ybi; Thu, 18 Jul 2019 02:14:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyioPG7jfOoLSlw8kSk2DHFLBCNGIqL8GTfRzgetE/Hf1BNUNjG1WaceblcEQPAQexpLwst X-Received: by 2002:a65:6497:: with SMTP id e23mr44822367pgv.89.1563441250870; Thu, 18 Jul 2019 02:14:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563441250; cv=none; d=google.com; s=arc-20160816; b=JthoXYUMAMiprF5JXiviy0Ld7zKHXfUf1dJ9DIKdn7YumKOTUJtP6DUxBBcj+Zh9cf mEPP8AfMcmgb2vNxWNRgKSAfzm7JSEXl3ZraklEQa23E+HzBiY+wA7HkBx6L/1Tgqti3 2uXhX9z0iSId1TduG4KVvGnmA3/9z1+2rWf/LbwXODKFnWWd904zALeA1tp7bjcjJpl2 QWy1c9PS3rqt8hhvz9YR43a2GCFR119HicI7Zk0o3mXEr3oks2R067quvD+D+V6btZCc E0N1tPFmCWZEidXPYl+xV2nXP1BhI3xrf5qEXb+3h1JKYuwvpYH2OkTHPtnkgbOLTqGE TI6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=VE9Z6zxmfXTuwvVdc9bppmyX7c7RCc05288z6+j3lis=; b=gdfIHKo/+CEc/5WmxUzq5IBRKU7v1gWyM1O9atIizSRwyjcC6cEN22Gd+w7akyEuvb M8c0Ab+FtenkMrsmzlHtgsWOrxUMS4UsENnGriere0QYoViUvj+1W3e6SUyTzeWknQx/ rcBC+BaFTEzUzPeXDBgt/nF8zVV23HH3zYVysnOBpS9IJgYqbUvrREUWK/6AK2W1QkZF pCB1QU04AURX3LYT9nsDxFAvVm33R5rfE7Igh4bvxpZPRmY4SELYccZcd159wGlJiwAK KR6Ec2r9PbeXlAA5hC6emW0GNX6zx92h1DZ6agrcsjEX758W6NSPv2l/4Y2avUA+53JZ Jq/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h36si2035588plb.199.2019.07.18.02.13.53; Thu, 18 Jul 2019 02:14:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbfGRJM6 (ORCPT + 99 others); Thu, 18 Jul 2019 05:12:58 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:2485 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfGRJM6 (ORCPT ); Thu, 18 Jul 2019 05:12:58 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15d3037fea81-9cdbf; Thu, 18 Jul 2019 17:12:30 +0800 (CST) X-RM-TRANSID: 2ee15d3037fea81-9cdbf X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.105.0.243]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee55d3037fdf8b-f6500; Thu, 18 Jul 2019 17:12:30 +0800 (CST) X-RM-TRANSID: 2ee55d3037fdf8b-f6500 From: Ding Xiang To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] libfs: fix obsolete function Date: Thu, 18 Jul 2019 17:12:28 +0800 Message-Id: <1563441148-31741-1-git-send-email-dingxiang@cmss.chinamobile.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org simple_strtoll is obsolete, and use kstrtoll instead Signed-off-by: Ding Xiang --- fs/libfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/libfs.c b/fs/libfs.c index 7e52e77..69cc01d 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -883,7 +883,8 @@ ssize_t simple_attr_write(struct file *file, const char __user *buf, goto out; attr->set_buf[size] = '\0'; - val = simple_strtoll(attr->set_buf, NULL, 0); + if (kstrtoll(attr->set_buf, 0, &val)) + return -EINVAL; ret = attr->set(attr->data, val); if (ret == 0) ret = len; /* on success, claim we got the whole input */ -- 1.9.1