Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2180912ybi; Thu, 18 Jul 2019 04:39:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdXihROCifpusObCu4jA14xNWVur4z5qKqUZG/A+Bse2cnTh0ra4xCPp48qwMsr+zpqxxZ X-Received: by 2002:a17:902:8696:: with SMTP id g22mr48379373plo.249.1563449944707; Thu, 18 Jul 2019 04:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563449944; cv=none; d=google.com; s=arc-20160816; b=B78qjmgdIGhqDm9nUwMzVtwosrz6rtnyl3otzhO5KZS3O3SG8LmPNhZ1OH6Oism5/a 56PwAZsynms4qBQ1M/ZqRUkK85PZspvIwktvW+P/vUMIAaZY01SZ9wyEWNTaAFVOJKDJ DNIlU2Vzw/GLKdg0HtIxkcABBcQkgWfAG7Lt5uMksG4Zh6ZI1gl8omzCNtlVng+64Qt/ 275B0oIIaPKxGzaoAIDoZeZw86qHWOsSI+PoGp9e+czWxFKr5h/HQmrGcNwtBMmgKKlh Lx+SVahJFC9JXXaPECr4d6HXWKemKHDyRtfmWOAg3mUOYIfE4Q9ie6Mrp1+YrnAI5zTx qCXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=jB9Aw5KfHyl/CQsvEwqGjOKL3wA2BLGM5nAjAbT4jR4=; b=hud3lH1lP4Vy2akqVxRdfZbTQYqCO6hFxEEAXMx9KGrOTd8nynHKhw+45lJFOHkXrJ kMussASA7Mc9RTDWsmz/3Nn/rLsKbDHi9UgB1kpvy0s57KIZWBk0iqW9lTd/b0VuE0pq CG6JcwP2rGrsFth/bxF8lFRDQMhWoC521C7GYdHfHlop6cv2/+vDR2YQ/SvPJZm+TtLL LhcnJjP1Zu/l+je+u42UiMxjmdCvKb7hDg8kt7OxC/ZSg8VofhCNXPOIKfNNQjLxwBGa A0eYziJpPX0USaFu/gxB+g3d8m+YzNahB1X8z1FMot2vR2Ul1Ymh4iTyw1Lm+ia28+JX cJpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si688417plh.380.2019.07.18.04.38.48; Thu, 18 Jul 2019 04:39:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390078AbfGRLgx (ORCPT + 99 others); Thu, 18 Jul 2019 07:36:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbfGRLgw (ORCPT ); Thu, 18 Jul 2019 07:36:52 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FA2A3082E42; Thu, 18 Jul 2019 11:36:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8485A5D71A; Thu, 18 Jul 2019 11:36:52 +0000 (UTC) Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3EF4941F40; Thu, 18 Jul 2019 11:36:52 +0000 (UTC) Date: Thu, 18 Jul 2019 07:36:52 -0400 (EDT) From: Jan Stancek To: Peter Zijlstra Cc: Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, dbueso@suse.de, mingo@redhat.com, jade alglave , paulmck@linux.vnet.ibm.com Message-ID: <466627724.868829.1563449812023.JavaMail.zimbra@redhat.com> In-Reply-To: <20190718110928.GT3463@hirez.programming.kicks-ass.net> References: <20190716185807.GJ3402@hirez.programming.kicks-ass.net> <20190717131335.b2ry43t2ov7ba4t4@willie-the-truck> <21ff5905-198b-6ea5-6c2a-9fb10cb48ea7@redhat.com> <20190717192200.GA17687@dustball.usersys.redhat.com> <20190718092640.52oliw3sid7gxyh6@willie-the-truck> <79224323.853324.1563447052432.JavaMail.zimbra@redhat.com> <20190718110446.GC3419@hirez.programming.kicks-ass.net> <20190718110928.GT3463@hirez.programming.kicks-ass.net> Subject: Re: [PATCH v2] locking/rwsem: add acquire barrier to read_slowpath exit when queue is empty MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.17.163, 10.4.195.22] Thread-Topic: locking/rwsem: add acquire barrier to read_slowpath exit when queue is empty Thread-Index: 2FC8jkf3xWoTPr5a8SlywdIbna06hA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 18 Jul 2019 11:36:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > > It's simpler like so: > > On Thu, Jul 18, 2019 at 01:04:46PM +0200, Peter Zijlstra wrote: > > X = 0; > > > > rwsem_down_read() > > for (;;) { > > set_current_state(TASK_UNINTERRUPTIBLE); > > > > X = 1; > > rwsem_up_write(); > > rwsem_mark_wake() > > atomic_long_add(adjustment, &sem->count); > > smp_store_release(&waiter->task, NULL); > > > > if (!waiter.task) > > break; > > > > ... > > } > > > > r = X; > > I see - it looks possible. Thank you for this example.