Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2210446ybi; Thu, 18 Jul 2019 05:06:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxIt4B/+u1PJvNVNqTTIsABUWywnaVGhX3bgSwjsFsYO2s94iSFmriQ3BwHDab+KKg48Edt X-Received: by 2002:a63:2264:: with SMTP id t36mr43097697pgm.87.1563451568466; Thu, 18 Jul 2019 05:06:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563451568; cv=none; d=google.com; s=arc-20160816; b=Xg0Js0vbro79lEUymaft2EPfFNiqk3tdpReYqTajyQ2Twel0sHON07M0QQvZ+SyXVD Q3LJ0lQuIDTdf1z1hFd7b9kHEgKO7nddv6Uq9WVPSG89GkUMFTJKrgKcWso9vkdP+ZLy L5rK2sUBFBKbV/fbRdwKvFuANiaNz/VRy/IzbWvpcjVZtBLgDOsbBt56gbgGUg9TAN5O amE8e8acT80oiEjgFzywP6MVA8ksI3P7rJQCNV33eGu2+HHQC/HPY3ktqOmWsovCwg0f ax3JbvSBt+wfLWpLE1lO3iUbKlwFNmAVDwT4YQgjZ+W5E+nWRAZywnE6RuZpc6a5bw0C 6jag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :organization:from:references:cc:to:subject; bh=/FBxtDdv4LDI8I0cyggrLzGSKDHL/54SSnzmyoZVZsY=; b=gb6J7T0IhRC24027IQh6/xjw4Wd/HxOITqBKfoP+eAXsCCvAdWJJxAK3VBbrj5t7om EFPJ579XYG6x54WT124hREAxjtsUYf9WL3+g3nRw6rOwWlLMSTVbJ+5ehZ1nJwIoNUKY swozq/p1EcvP7jernOnUbjy90InE5QWj2jAbWJCi5Ywc9K/5lO4QFbmrZ7LvSsPbpAr0 BSRo5M6FDObOWexYW0NXuft+D4f8sVBV932CWTbLZVLNoijvYVvwANi2daWL5nlaK1+3 AWaRsjJmI/bK0Gnn4Czhxw2OGONPa1eNOp7/O0HNcOFAEGgIJJCk7ccWODAwtx/qFoXH DBIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v136si27513794pfc.9.2019.07.18.05.05.51; Thu, 18 Jul 2019 05:06:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbfGRMEH (ORCPT + 99 others); Thu, 18 Jul 2019 08:04:07 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59520 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726608AbfGRMEH (ORCPT ); Thu, 18 Jul 2019 08:04:07 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6IC3r23067938 for ; Thu, 18 Jul 2019 08:04:05 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ttqxq17c4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 08:03:59 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 13:02:28 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 13:02:24 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6IC2Ahe29557076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jul 2019 12:02:10 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D05D65206C; Thu, 18 Jul 2019 12:02:23 +0000 (GMT) Received: from [9.152.224.207] (unknown [9.152.224.207]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7030552077; Thu, 18 Jul 2019 12:02:23 +0000 (GMT) Subject: Re: [PATCH] vt: Grab console_lock around con_is_bound in show_bind To: Daniel Vetter , Intel Graphics Development Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman , Nicolas Pitre , Martin Hostettler , Adam Borowski , Mikulas Patocka , Daniel Vetter , Sam Ravnborg References: <20190718080903.22622-1-daniel.vetter@ffwll.ch> From: Jens Remus Organization: IBM Deutschland Research & Development GmbH Date: Thu, 18 Jul 2019 14:02:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190718080903.22622-1-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19071812-0012-0000-0000-000003340C87 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071812-0013-0000-0000-0000216D8E5C Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-18_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180129 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18.07.2019 um 10:09 schrieb Daniel Vetter: > Not really harmful not to, but also not harm in grabbing the lock. And > this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: > More locking checks"). > > Reported-by: Jens Remus > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Nicolas Pitre > Cc: Martin Hostettler > Cc: Adam Borowski > Cc: Mikulas Patocka > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Sam Ravnborg > --- > drivers/tty/vt/vt.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Thank you for the quick fix! Looks fine to me. Did test with cat as well as our dump2tar utility. The warning is gone. Tested-by: Jens Remus Regards, Jens Remus -- Linux on Z and z/VSE Development & Service (D3229) IBM Systems & Technology Group, Pure Systems & Modular Software Development IBM Data Privacy Statement: https://www.ibm.com/privacy/us/en/ IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Matthias Hartmann Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294