Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2275016ybi; Thu, 18 Jul 2019 06:03:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxZ4MpoI2izix8YxWTSGrQet8b7V8y68y2vORrLQmBsQHKWt/0NNcSMe8U548KYHCvGw0vY X-Received: by 2002:a17:90a:29c5:: with SMTP id h63mr48801483pjd.83.1563455014837; Thu, 18 Jul 2019 06:03:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563455014; cv=none; d=google.com; s=arc-20160816; b=UWsb2JLkX5HVgVBKMUtOvmXdC6bTbU0rF6FbgWbZ5YiwVE20lgS8XmHiQjXD7GVF6t CH2K8NSqfCiskblL+x1+fF7A5VBBnpW6eJaBIDTWbLbHO86O/vZeFhr6LTNo0NthnfpA FPNDfe3hFmKtvFV8OfD63c6asX4T/SSbOYVEOp4loShdt/ZqoyclAeu80luBYCfJv51h 04mQlzuxDWTK2/lKOD9DIc+rCHS0iSpymczslAqetKC6CoqMk2duKHHA1WCcU15Xtd3g PJvjmQP4o6OY13RNb6wpRh6AoKWKC5tmjA3zhM3xmh8TIvYJiIjs1K98yrY5OlbZnsRc U4mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:organization:references:in-reply-to:subject:cc:to:from :date; bh=uuPMQropoPCWD4OC3K1XPyNh/Zn7M0rqIU3oYxW+XhE=; b=GupS/zXRWRjeKjSMbMLeBgI4fsi0cPUqew59K6Jn+ufeegk1KPsYbzQQj9cnsEYtbI D7OjfCyKoT2tNz17G2tTN7LWZCVxBPdBUxRYOPdZGfNfnw0+WM2PCWJ0uwIJAM9dOpgV i3xFu6UAxGMu0ar9OThKS1/XD61bNMNEq2pJ3ru1C+p1g2cfZ1A6FA4iXr53Irpbeyjo Oda3H+yLbcbEFuQXpSXqAoOrCJtv/2EkI1j9N5WYkpMjU8FMkUUXRJkXBgQM3IuPkZ9Y LhOZoQw3NDbhXAx9nzVjVQizJ2TrIQb6frW5Bim6gYpJ5gB3UGoiwt3XwYVRZvsWY9Ir SuZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 130si2764209pgg.18.2019.07.18.06.03.18; Thu, 18 Jul 2019 06:03:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbfGRNBg (ORCPT + 99 others); Thu, 18 Jul 2019 09:01:36 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:62826 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfGRNBf (ORCPT ); Thu, 18 Jul 2019 09:01:35 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6ICwD2U086119 for ; Thu, 18 Jul 2019 09:01:34 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ttrxerxpu-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 09:01:34 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jul 2019 14:01:31 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 18 Jul 2019 14:01:26 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6ID1O1I46399696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jul 2019 13:01:24 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3CC511C04C; Thu, 18 Jul 2019 13:01:24 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B18911C04A; Thu, 18 Jul 2019 13:01:24 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.224.219]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 18 Jul 2019 13:01:24 +0000 (GMT) Date: Thu, 18 Jul 2019 15:01:23 +0200 From: Halil Pasic To: Christoph Hellwig Cc: Thiago Jung Bauermann , x86@kernel.org, iommu@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Marek Szyprowski , Robin Murphy , Konrad Rzeszutek Wilk , Alexey Dobriyan , Thomas Lendacky , Mike Anderson , Ram Pai Subject: Re: [PATCH v3 6/6] s390/mm: Remove sev_active() function In-Reply-To: <20190718084456.GE24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-7-bauerman@linux.ibm.com> <20190718084456.GE24562@lst.de> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19071813-0028-0000-0000-00000385B410 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071813-0029-0000-0000-00002445DDD0 Message-Id: <20190718150123.4230a00c.pasic@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-18_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=994 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907180135 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jul 2019 10:44:56 +0200 Christoph Hellwig wrote: > > -/* are we a protected virtualization guest? */ > > -bool sev_active(void) > > -{ > > - return is_prot_virt_guest(); > > -} > > - > > bool force_dma_unencrypted(struct device *dev) > > { > > - return sev_active(); > > + return is_prot_virt_guest(); > > } > > Do we want to keep the comment for force_dma_unencrypted? Yes we do. With the comment transferred: Reviewed-by: Halil Pasic > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig