Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2412865ybi; Thu, 18 Jul 2019 08:02:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzgEDw3fKPJBawQYnhuAwlp4qlycWcgxJalLterJV4SeANYlBwm7dbRHu8AFAB5Z5YMTrfE X-Received: by 2002:a63:7358:: with SMTP id d24mr48091918pgn.224.1563462153673; Thu, 18 Jul 2019 08:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563462153; cv=none; d=google.com; s=arc-20160816; b=RM1rkTbna3TgPYQewtvgJ6l4SNoEtzSWk7E17x7GzFUpHG0nPY3P7RL5cwQqQ4iMxf JglcP6kgvoRhA4dI7aD15pEbDDAqDwhOabNsq141QDMNRwwksnWPm9swiXCVkhJ8Fol8 HUgZDiRLOA+e5i6/3Q9x88dgKrvjUGYhXLaWSIzQaG/j3N2x3mvaOgxz/JBrKu9TVrp7 9H933iF/IjA80RZ/ZI6S28CI3BqmWxdlsJLjTWaqaNpSio2ODzssYzgMTCickhCT++I0 mdRL11WmwWtH6bm94hHbK1nD8ExGy9xVNq9ngNNgeCfS4HrE00TcGtSRBpPhvl1HP4CP MZDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=adVwYs4dDzkMsZ1th/T41+ijOMVhzdth9RtU8OBv1YY=; b=NXrEqezRDpQqUyEJ/hB+wJQQd12VxRHZI//GBFTmxWNnu1i9ixSc04RcEysmvGpUm5 /3+iSCuT2ZWOtfaJN/eYz5WeKY7GD69pcdIig1dv/wDfodpNiGwS37y3wahprV2WwDzD 0eSfZW0Nfg3a97hCEBnIUIU/tplvgrYDdvO7X5HsyZz53npKAD5B1GMPN7PMBCjSsS4o hc4T3v3PPv8OSSeuBFW+ep9kUC0SYlSKu2wgf2Dn/PNc09z8Ar1UEXf+M9uSgo3/sJsD zf7SCtupTI5jIcQMNmyIk9vtBEAjQGbdUeZgH+nQ4zrkjcGVEmuKo/Hn+BPSkQw8iJKi ayOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si2196703pgb.201.2019.07.18.08.02.14; Thu, 18 Jul 2019 08:02:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390648AbfGRPBD (ORCPT + 99 others); Thu, 18 Jul 2019 11:01:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42132 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbfGRPBD (ORCPT ); Thu, 18 Jul 2019 11:01:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C3104A3B5F; Thu, 18 Jul 2019 15:01:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id 1CAC5605B1; Thu, 18 Jul 2019 15:00:58 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 18 Jul 2019 17:01:02 +0200 (CEST) Date: Thu, 18 Jul 2019 17:00:58 +0200 From: Oleg Nesterov To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Suren Baghdasaryan , kernel-team@android.com, Andrea Arcangeli , Andrew Morton , Christian Brauner , "Eric W. Biederman" , Tejun Heo Subject: Re: [PATCH RFC v1] pidfd: fix a race in setting exit_state for pidfd polling Message-ID: <20190718150057.GB13355@redhat.com> References: <20190717172100.261204-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190717172100.261204-1-joel@joelfernandes.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 18 Jul 2019 15:01:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17, Joel Fernandes (Google) wrote: > > exit_notify > do_notify_parent > do_notify_pidfd > tsk->exit_state = EXIT_DEAD OOPS. Somehow I thought it sets exit_state before do_notify_parent(), I didn't even bother to verify this when I reviewed pidfd_poll()... Sorry, can't read the patch today, will do tomorrow. Oleg.