Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2465127ybi; Thu, 18 Jul 2019 08:48:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5OfTc5Y191pE+GxnLx/ti+3MqOOy61bVJPcBuolwqRFwOedKZzILdkwwieD3wM8f5d2DN X-Received: by 2002:a17:90a:8a0b:: with SMTP id w11mr51475268pjn.125.1563464935240; Thu, 18 Jul 2019 08:48:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563464935; cv=none; d=google.com; s=arc-20160816; b=R19Y2y2arZl5TNMy6fBMGZID3g9aRX+7/2krNnnDwuCdrcGQqYLYcQq0zxd70+vkGd nxGWG95mEwXdCnwpk1f+uK8iH1qho/32aequz3yVKeD9gscrTqwZpoizbwnZaX7Yfl0Y /95H6IX0f88jEk6WAa7p+Ke6zf5IvJ2A52PXzsSSBEdNOM5S/Jem4BXqnXKOEUvzMiZE f3oCrAO0wFhI7tfNZDTQAiRkpuYxpKzTwYyRB942KS0Bg6ySLK4TlCYVGl4pZwFWhCjs t/N6HCT/y1HpEOjzbux9WpmK5N/fSBTI/GWnu8hx5Ywju2GTu/NsKC44aWDSOgdn946U km6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kXOJ/QlGkR4KXrYJYUOzJz9wPm3YZoed9Pbco5xDfoY=; b=cuBVZdSxPK66qDkPoyx0kLEz74JcI3BDlogxZpmVjcpe8ss6HFhKSieVohC+tXxj1u COXOF/37b2ht2l/tI/vQL/uvJlM3/05wrMNpKZb63Io36ER17Zwdoj7AoT26HwDZ9aLh rWBg8V3SLPafrD1RcmHePqfI71lobrFJHwEKeTcVY8saqG9P4fGHEhA7HI6xDMpGzZMS 8mFiSMsBHETTHIEdnXKBRSIVOUmCK/OBW7QT38H/IOZ9U3c2a1neFedzS8vR4L6Dr03a zLYy45LOEgcVEyr9DV0hWyzhAU65wjzuviYthmjHrMjCiRrhl3qQJCAhri4SLrecJyfA eOPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v136si28053430pfc.9.2019.07.18.08.48.38; Thu, 18 Jul 2019 08:48:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390597AbfGRPqb (ORCPT + 99 others); Thu, 18 Jul 2019 11:46:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35522 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728120AbfGRPqb (ORCPT ); Thu, 18 Jul 2019 11:46:31 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1FFE30ADC81; Thu, 18 Jul 2019 15:46:30 +0000 (UTC) Received: from laptop.jcline.org (unknown [10.13.105.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45B2110021B2; Thu, 18 Jul 2019 15:46:28 +0000 (UTC) Received: from laptop.jcline.org (localhost [IPv6:::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by laptop.jcline.org (Postfix) with ESMTPS id 9FCF6704C8E5; Thu, 18 Jul 2019 11:46:27 -0400 (EDT) Date: Thu, 18 Jul 2019 11:46:26 -0400 From: Jeremy Cline To: Benjamin Tissoires Cc: wbauer1@a1.net, Nicolas Saenz Julienne , Jiri Kosina , Dmitry Torokhov , "open list:HID CORE LAYER" , lkml Subject: Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage Message-ID: <20190718154626.GC25351@laptop.jcline.org> References: <20190611121320.30267-1-nsaenzjulienne@suse.de> <5346893.KeHrH3GHoD@linux-lf90.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 18 Jul 2019 15:46:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 03:36:03PM +0200, Benjamin Tissoires wrote: > Hi Wolfgang, > > On Thu, Jun 13, 2019 at 1:49 PM Wolfgang Bauer wrote: > > > > On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoires wrote: > > > On Tue, Jun 11, 2019 at 2:13 PM Nicolas Saenz Julienne > > > > > > wrote: > > > > NOTE: I CC'd Wolfgang as he's the one who can test this. > > > > > > I'll wait for Wolfram to confirm that the patch works before pushing then. > > > > My name is Wolfgang, not Wolfram... ;-) > > ouch, sorry for that (I am more used to talk to the I2C maintainer apparently) > > > But never mind. > > > > I tested the patch meanwhile on top of kernel 5.2.rc4, where the mouse wheel > > actually worked. > > Actually, I am a little bit lost here. > > The patch mentions a fix of c01908a14bf73, which is in 5.1 final. > So if your mouse works in 5.2.rc4, I am not sure how > HID-a4tech-fix-horizontal-scrolling.patch could break it. > > Could you be slightly more specific in what "works" and what doesn't? > For what it's worth, at least one user has hit this issue in Fedora starting on stable kernel v5.1.17[0] which has commit abf82e8f7e9a ("HID: a4tech: fix horizontal scrolling"). Applying this patch on top of v5.1.18 fixed the issue for them. [0] https://bugzilla.redhat.com/show_bug.cgi?id=1730762 Regards, Jeremy