Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Wei Wang <wei.w.wang@intel.com>, Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        Xavier Deguillard <xdeguillard@vmware.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "pagupta@redhat.com" <pagupta@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        "yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
        "nitesh@redhat.com" <nitesh@redhat.com>,
        "lcapitulino@redhat.com" <lcapitulino@redhat.com>,
        "aarcange@redhat.com" <aarcange@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "alexander.h.duyck@linux.intel.com" 
        <alexander.h.duyck@linux.intel.com>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal
Thread-Topic: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal
Thread-Index: AQHVPVETq+d/PdgRAE68BsHO2xGkqabQTVWAgABNFwA=
Date:   Thu, 18 Jul 2019 17:02:07 +0000
Message-ID: <4FC18511-DD19-4B10-BCAF-906E264B0411@vmware.com>
References: <1563442040-13510-1-git-send-email-wei.w.wang@intel.com>
 <20190718082535-mutt-send-email-mst@kernel.org>
In-Reply-To: <20190718082535-mutt-send-email-mst@kernel.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B3E1CA15BF28004E91F935580443763C@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8161b6-8a25-4510-6e31-08d70ba1aac1
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 17:02:07.5889
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: namit@vmware.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4775
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Jul 18, 2019, at 5:26 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>=20
> On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
>> Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
>>=20
>> A #GP is reported in the guest when requesting balloon inflation via
>> virtio-balloon. The reason is that the virtio-balloon driver has
>> removed the page from its internal page list (via balloon_page_pop),
>> but balloon_page_enqueue_one also calls "list_del"  to do the removal.
>> This is necessary when it's used from balloon_page_enqueue_list, but
>> not from balloon_page_enqueue_one.
>>=20
>> So remove the list_del balloon_page_enqueue_one, and update some
>> comments as a reminder.
>>=20
>> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>=20
>=20
> ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. P=
ls take a look.

Thanks (Wei, Michael) for taking care of it. Please cc me on future
iterations of the patch.

Acked-by: Nadav Amit <namit@vmware.com>