Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2586841ybi; Thu, 18 Jul 2019 10:44:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUtBaRHQ601BKvovcAJ7MR5oTIOA5/AmW/md8w4bUHDGCm3bwSi1rOBwXg7FfQ39Jsn/rD X-Received: by 2002:a17:90a:23a4:: with SMTP id g33mr53811082pje.115.1563471841781; Thu, 18 Jul 2019 10:44:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563471841; cv=none; d=google.com; s=arc-20160816; b=dvC/LC5utDgbFCDGgT6pFGMQ8ehNfHdFcA4RVVrEpHXr3I9cZ2ie0mpOWUU7BDNmE+ Exsx/vGpqfxLKJgpI+HUITVCGCt3sLVJkEXPKkTKJAMTQfaaOykTVh9I0DVaAWgNxPb2 YrmIxlrFyac/6HM+10Iaah83PJ+lMzCV/gQbPnZxc90S656LfhECSUq5cIG7pWpPezCS HSUn+1Mfrb+5DdMCmi5npRRO80BMExf1pWPb2cUewSxf0LtCKbYKdUk6GpkwDHJyfTCh EMbEpTOyvx62Yz+VbdBT40tSpipOkB2YJWsn5C8YiR1fsnP/kT2+Hlzpbfb6XufAe71M NKcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=QDI5IqDp9suDRjNaAkUm8piJMHGnuMn5yRUtK5Yo2lI=; b=McXSz7P+PaoFJW5yFZCIkeZwfNrkBoMnNgkOg0pgmczwQ6SmzjjCxoamSeX6Bb9DUr JjIEGI9ro484WYky48OPkCiU9NZXgg2gAb1DccEEp5f55ddJTuajaedSVKOOczVBultT 4zyBlGLyhXPUZR157D05frWOxiGaux1GDRU5Si6BekInmGNnKstisJxCWjv4NRWGOR3x /Z1gZ50FpRrzZNJUS1bGyoH7GuOjE+jhm2ccoNUtplnhxN3QwL/QOknCJZnLyjH3Kxzk sTwuHVUxnaV4FEVrmLrdyzHzSYLmqFrusWqCIv2u5vrslzfxn6BSVu0wg2WBRdxVtYPJ 7hrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=pqmyfLvx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13si2903636pgn.420.2019.07.18.10.43.45; Thu, 18 Jul 2019 10:44:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=pqmyfLvx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728250AbfGRRmA (ORCPT + 99 others); Thu, 18 Jul 2019 13:42:00 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14640 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728111AbfGRRl7 (ORCPT ); Thu, 18 Jul 2019 13:41:59 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 18 Jul 2019 10:41:55 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 18 Jul 2019 10:41:57 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 18 Jul 2019 10:41:57 -0700 Received: from [10.110.103.56] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 18 Jul 2019 17:41:56 +0000 Subject: Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks From: Sowjanya Komatineni To: Dmitry Osipenko , , Michael Turquette CC: Peter De Schrijver , Joseph Lo , , , , , , , , , , , , , , , , , , , References: <16f8b146-2581-a842-4997-53ab05b62c70@gmail.com> <71272e9a-0f2a-c20d-6532-7e9057ad985c@gmail.com> <78fd19b9-b652-8ac3-1f57-3b4adadee03f@nvidia.com> <351a07d4-ba90-4793-129b-b1a733f95531@nvidia.com> <9271ae75-5663-e26e-df26-57cba94dab75@nvidia.com> <7ae3df9a-c0e9-cf71-8e90-4284db8df82f@nvidia.com> <46b55527-da5d-c0b7-1c14-43b5c6d49dfa@nvidia.com> <2de9a608-cf38-f56c-b192-7ffed65092f8@nvidia.com> <5eedd224-77b0-1fc9-4e5e-d884b41a64ed@nvidia.com> <89f23878-d4b2-2305-03e5-8a3e781c2b02@gmail.com>

<4141181d-7162-0321-71b6-33abf11f631c@gmail.com> Message-ID: <419e1b16-683e-1b56-7334-50d87368c1b9@nvidia.com> Date: Thu, 18 Jul 2019 10:41:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1563471715; bh=QDI5IqDp9suDRjNaAkUm8piJMHGnuMn5yRUtK5Yo2lI=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=pqmyfLvxFnfQ1aktHQK/J4AcWiSwU2R+a0KUdxArWu+4aFuEhJ0+cMjBL4vne6j7N BruO6PUAtR/Coz64r22DvkTXeSDlJ9rySclJ/lWtpY+RTwKemflJv5YKTd3tooz10V mkT49WPy0DlDRQiXX7Q7Sn7W4F/6VFLznxSc3yyektij5D6JVy/npmshn3kVId1LK4 8lQA7j6tOn/pL2oa6ZA/h2k/HPtWeHWXeb0cj12w+MK2AS/AG3iF63AVBx94tUX9az h1JPxGQnub4ozmyGa3gdASyEeinSrJWBVPNlW1a/RKiqmrk0qxLmBDMpJmzQaSjZZI b6TF+5P/SojHw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/19 10:22 AM, Sowjanya Komatineni wrote: > > On 7/18/19 9:34 AM, Dmitry Osipenko wrote: >> 18.07.2019 4:15, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> [snip] >> >>>>> Please try to fix all missing dependencies and orderings. >>>> Peter, >>>> >>>> dfllCPU_OUT is the first one to go thru restore when >>>> clk_restore_context traverses thru the list. >>>> >>>> dfllCPU_OUT has dependency on DFLL_ref and DFLL_SOC but this >>>> dependency is unknown to clock-tree. >>>> >>>> We can add DFLL_REF and DFLL_SOC as parents to dfllCPU_OUT during >>>> register so dfllCPU_OUT save/restore happens after their parents are >>>> restored. >>>> >>>> But DFLL needs both of these to be restored before DFLLCPU_Out and as >>>> DFLL_SOC restore always happens after the REF, thinking to add >>>> DFLL_SOC as parent to dfllCPU_OUT so save/restore follows after their >>>> dependencies. >>>> >>>> Please comment. >>>> >>> Did quick try and I see by adding dfll-soc as parent to dfllCPU_OUT,=20 >>> its >>> in proper order after all its dependencies. >>> >>> Can now add dfll save/restore to do dfll reinit during restore.. >>> >> If dfllCPU_OUT can work properly with dfll-soc being disabled, then this >> kind of dependency isn't very correct and just papers over the real >> problem, which is that there should be a way for CCF to specify multiple >> dependencies for the clock or the reverse ordering should be used for >> the restoring. > > dfll will not work without dfll-soc enabled. > > CLDVFS control logic is split into 2 clock domains. dvfs_ref_clk and=20 > dvfs_soc_clk. > > Majority of the control logic is clocked from dvfs_soc_clk for=20 > interfacing control registers. > Note on reverse ordering for restore. Currently restore order goes thru=20 clock list and for each root goes thru parent -> child restore. this order is correct and also all clocks are parented properly so they=20 follow proper order. dfllCPU is the only one where current driver doesn't take care of=20 dependency in dfll_soc which gets enabled only after dfll_ref. Based on dfllCPU control logic module design, dfll_ref and dfll_soc=20 should be enabled prior to dfll init/enable. So parenting dfll_soc to dfllCPU keeps proper order.