Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Jul 2019 11:46:38 -0700 (PDT)
Message-Id: <20190718.114638.2086531826521437029.davem@davemloft.net>
To:     f.fainelli@gmail.com
Cc:     justinpopo6@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, opendmb@gmail.com
Subject: Re: [PATCH] net: bcmgenet: use promisc for unsupported filters
From:   David Miller <davem@davemloft.net>
In-Reply-To: <5f6422b5-e839-1600-6749-048a7e31ea96@gmail.com>
References: <1563400733-39451-1-git-send-email-justinpopo6@gmail.com>
        <5f6422b5-e839-1600-6749-048a7e31ea96@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 17 Jul 2019 20:38:47 -0700

> 
> 
> On 7/17/2019 2:58 PM, justinpopo6@gmail.com wrote:
>> From: Justin Chen <justinpopo6@gmail.com>
>> 
>> Currently we silently ignore filters if we cannot meet the filter
>> requirements. This will lead to the MAC dropping packets that are
>> expected to pass. A better solution would be to set the NIC to promisc
>> mode when the required filters cannot be met.
>> 
>> Also correct the number of MDF filters supported. It should be 17,
>> not 16.
>> 
>> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable.