Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2668343ybi; Thu, 18 Jul 2019 12:09:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWudceZLNuNt4IupvjmoywV/w/BpZmItoV8S3UKQKXH0QLyDFlujCwG6KwxTDfNIbNZtQa X-Received: by 2002:a17:90a:21cc:: with SMTP id q70mr54301636pjc.56.1563476967483; Thu, 18 Jul 2019 12:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563476967; cv=none; d=google.com; s=arc-20160816; b=avm2TAZjBdIvutz+iV+lRXSJOkVXUoZKhirg4ehAVrgu9v6t9IBBRePYtmpXy8fsTV 1sQIVuj9OUU3Qoc1l1ls2RLD47HE+ZfpUzy3LgE/6tJUBgbABqxzZ1oY2dhRbvDSfn0H nXKGIMQ/UHAIbnXsT3orimr0+84zaquuNmTZhuSSiprEkOFHQ3vq5r8n7aQUsu3N5bqF vwkBpGGfmz/Waj2zu9lRMfZYQBVeGQYrejtLB0uTjW+eBQnu+fmKkiNc+5zB0Qw1FrHM zwTPHk2Q7dlq4mKOnvaf6R0/qzjVwcicJsltElczsMHun3hur9kANbFrdjXgMLU+rsKc 1EMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=lLKo0gFxmNq6TdJf0ZVePS6Fu/f+hk9K5ftPTQKsHzY=; b=alNwSq/1mHd/49H+OeC9XxucsT6j1/1n5SDSe7EJau6BRdyGsdXjGrPAMLVGrQsRm6 luU1FOZLtqfbKfTxUxr4mqBpipb1y/vgekE9O9z05DVFL1xSKsoOGTlQNobWFey8RU9R 7elQOq7PyBMJMEI6EQAzmnHB+8NmKkPMfE9H5iAtd+Etl8CAYaNAIPa1tun8x32tiz2r jAxL6wk6zKimErlLI7n4SWv5rF820G3JuwZNIF89qczD+vxtxV+IJjng/JOLhSGpnftw wXdq/mGJtcMAOOZsVOtPmMYVzUbD196v3h2Fb9gS0mVAwCzLO0pDURFciVWYaa0Bulfg xVyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si375204pfk.201.2019.07.18.12.09.12; Thu, 18 Jul 2019 12:09:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391165AbfGRTIb (ORCPT + 99 others); Thu, 18 Jul 2019 15:08:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391028AbfGRTIa (ORCPT ); Thu, 18 Jul 2019 15:08:30 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 306741527DFBA; Thu, 18 Jul 2019 12:08:30 -0700 (PDT) Date: Thu, 18 Jul 2019 12:08:29 -0700 (PDT) Message-Id: <20190718.120829.1693127632426510179.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: pshelar@ovn.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] openvswitch: Fix a possible memory leak on dst_cache From: David Miller In-Reply-To: <1563466028-2531-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1563466028-2531-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jul 2019 12:08:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haishuang Yan Date: Fri, 19 Jul 2019 00:07:08 +0800 > dst_cache should be destroyed when fail to add flow actions. > > Fixes: d71785ffc7e7 ("net: add dst_cache to ovs vxlan lwtunnel") > Signed-off-by: Haishuang Yan OVS folks, please review.