Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2671532ybi; Thu, 18 Jul 2019 12:12:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQRFD7maEU/MeyIK0ikhLf85QAhNNHeN+67AgCiD78+aUvSrVNkLofFFC/WWGZnc9W/T68 X-Received: by 2002:a17:902:54f:: with SMTP id 73mr50859807plf.246.1563477156266; Thu, 18 Jul 2019 12:12:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563477156; cv=none; d=google.com; s=arc-20160816; b=nsYcG9krWBks21B75RqXmQ9egQhpAlbvGncbtjfTYao/XxeQcwK19zGxOHKPBp1iHR TPI0MDpBLRhABF1lmU9zf5yb9g0LN+japCFKw0churfNYk1uJHUM+v7JwsTsYu294Yv6 FNTOFz2aHaaqVlhBV+4nC/RJR19RrdaQU2dsA+FQOSea5Ju0UINZayAMEsPSLtjPOkW5 onWOr33uXSqtbpXNVCfvHuPmXkpSxKyxetVoUoY5zexcyZxmObBv3SCwgyo+4LWfZHCX QNZcop7wV8Qk6RfPRQw6rGeZnFQizPC+TiVo2Tq3M/VDzsNC4mK5EhIaza/ei5gKJxYD 4Gzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=pDVqLUvd3p9mk8J0Lm+NW/qugB+ncvvZg7eE9ObbJNA=; b=Mnl7Zjlai0hOpv0Yy/+R/rivNEvgTyTmXZc1Nm+RS3UUf8nGnauo+/+v9Jthl4zePs /pBsyiyMqGOxjuBJAqebdY+3Qeo6fiz2YLFzy6YJEyB6mlP48W/exY+waTswIrTE5SW+ bwVjugEXYTmHlJrkYPEZnW/Fj461U/qAcHOgbsIMUoauQOQUSS5lXjJDBuHzfzw8Vx+w 6JCeLjO7zzQMIiWGj2aO1tu8mPGGjkxUhnbfzwHsXqSteS68ZXstFz9KB6MccUAjyfFa BSnLgLl9MNOpA/iKU/Aw/RC5LPbLOw52zPepQVXLxXcb3dFvu32iO79OMwtb2AwsVi2a Vqlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az7si25048226pjb.51.2019.07.18.12.12.20; Thu, 18 Jul 2019 12:12:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391234AbfGRTLb (ORCPT + 99 others); Thu, 18 Jul 2019 15:11:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54428 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbfGRTLb (ORCPT ); Thu, 18 Jul 2019 15:11:31 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9EC8F1527DFC5; Thu, 18 Jul 2019 12:11:30 -0700 (PDT) Date: Thu, 18 Jul 2019 12:11:30 -0700 (PDT) Message-Id: <20190718.121130.1625873392550008613.davem@davemloft.net> To: saeedm@mellanox.com Cc: hslester96@gmail.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, leon@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/mlx5: Replace kfree with kvfree From: David Miller In-Reply-To: <76783a8ca91cb7d0e454cf699c4984243df0081d.camel@mellanox.com> References: <20190717101456.17401-1-hslester96@gmail.com> <76783a8ca91cb7d0e454cf699c4984243df0081d.camel@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jul 2019 12:11:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Saeed Mahameed Date: Thu, 18 Jul 2019 18:38:34 +0000 > On Wed, 2019-07-17 at 18:14 +0800, Chuhong Yuan wrote: >> Variable allocated by kvmalloc should not be freed by kfree. >> Because it may be allocated by vmalloc. >> So replace kfree with kvfree here. >> >> Fixes: 9b1f298236057 ("net/mlx5: Add support for FW fatal reporter >> dump") >> Signed-off-by: Chuhong Yuan > > Acked-by: Saeed Mahameed > > Dave, i guess this can go to net. Ok, applied.