Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190718113346.GA19574@linux-8ccs>
In-Reply-To: <20190718113346.GA19574@linux-8ccs>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 18 Jul 2019 12:20:46 -0700
Message-ID: <CAHk-=whjTFKB3TPPkgCvMX9P+C=hy2ZjhQy7C5reTQKV6MtuOw@mail.gmail.com>
Subject: Re: [GIT PULL] Modules updates for v5.3
To:     Jessica Yu <jeyu@kernel.org>, Prarit Bhargava <prarit@redhat.com>
Cc:     Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 18, 2019 at 4:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>
> Modules updates for v5.3
>
> - Fix bug where -EEXIST was being returned for going modules

Hmm.

I have pulled this, but this change makes me a bit nervous.

I have this dim memory of us having deadlocks in module loading
because module loading triggered other modules to be loaded, and we
had circular dependencies..

This is from years and years ago (that whole state check is not
recent), so my memory may simply be wrong, but I thought I'd mention
it...

                   Linus