Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2885711ybi; Thu, 18 Jul 2019 16:32:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8AuPQncY8t+m+EnKbQlBi2wlVoDJ4GVD5ZU54QzhhqxEb/MqdHtHHPVb/eG4tOTECCBoN X-Received: by 2002:a63:61c6:: with SMTP id v189mr44133052pgb.36.1563492771001; Thu, 18 Jul 2019 16:32:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563492770; cv=none; d=google.com; s=arc-20160816; b=bmJ5lL0kDZDvZWQN0TPhQyN11uaej6LtO33WzhxdbofwTcnF5R4aokU6uX72qPL1Jx PhmUl9egqLlDZ/jsJw7tn1guoV9rrWf3ffeRbrdsRvOcmby0ftNbsXwwuJQIOmzM8jXR uWv6hhg/MKXUCJVUCCumiaFu2akdBgVpLwc96XOu9eyd8QXqw+u1pgsnwbjPR2oeC3O2 9IpK6vePk54txUCU8Z1GRp7mFaNdzbYq595x2QJ9nMc+hiyeIQb9GWVxCy5pPXb2q7wh UqDD1cDHxNooVz/7zc+AQWRR82vsUfxOg41WgT43XjkDpQKypQGf3QlE6G8N8TuIfjA3 wd7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=m/4WnR0aeXf71ViDUCcm5Lq91YWsrUWrh0igWcQsd18=; b=yUvFAh2zVtWIRirldEYZJs/4EiCPa3Dp2AnuO8Elv27SJj/1F8F7SiyYkRWyu0SGK6 R3Y//mafvC5Vnil8Ui6PEbS/TxSg5bV3HiC2mRBlROYOL51OCmtmrx3+7RLvOrS1LWJ/ QYYw3La0LMwyMklWSt9EKAsK+XV2l6ee8g3uM/pz6BjBxKCAzFXv0vtkYZ1suW64gWA5 1DMdNMVSxSjsZISsKt9fZD7RzZ6O3ijsAGge0wU97lVSYvR+CaR/y3saHW4y+3fFnmrS gTKRHtiTTLaI9r5oapE+z4ePOL7J0Zl68wNauw+V+wguCU7peJ/eTcHWxTyDW5M4lX3W KLOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x24si4315962pfr.200.2019.07.18.16.32.34; Thu, 18 Jul 2019 16:32:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726188AbfGRXcK (ORCPT + 99 others); Thu, 18 Jul 2019 19:32:10 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbfGRXcK (ORCPT ); Thu, 18 Jul 2019 19:32:10 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8A45A1528C8C4; Thu, 18 Jul 2019 16:32:09 -0700 (PDT) Date: Thu, 18 Jul 2019 16:32:07 -0700 (PDT) Message-Id: <20190718.163207.289099133864098969.davem@davemloft.net> To: chuhongyuan@outlook.com Cc: csully@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gve: replace kfree with kvfree From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Jul 2019 16:32:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong YUAN Date: Wed, 17 Jul 2019 00:59:02 +0000 > Variables allocated by kvzalloc should not be freed by kfree. > Because they may be allocated by vmalloc. > So we replace kfree with kvfree here. > > Signed-off-by: Chuhong Yuan Applied, thanks Chuhong. GVE maintainers, you are upstream now and have to stay on top of review of changes like this. Otherwise I'll just review it myself and apply it unless I find problems, and that may not be what you want :)