Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2904516ybi; Thu, 18 Jul 2019 16:59:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlkQYUCxcYFeRV43RNOfJ0Y/C7DDyHfHY/W/q6IsDFBxM2mv59aZHow7hWsSgBT/a6bi0i X-Received: by 2002:a17:902:a413:: with SMTP id p19mr53549426plq.134.1563494375444; Thu, 18 Jul 2019 16:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563494375; cv=none; d=google.com; s=arc-20160816; b=v7DpzOcF48OsqWpcpjjsMwQNopwL3oEKhpy/RP9T4EVIKT84WyPMWU38QNkFjJNkGk WG1EbUmBBUaKa/31DZJfG3/NIu7ZN7IJ9ZciCQf0sjxF31bSS3ksM9B/qXbSsxqlM+to rmpn8MgahrfkmjnaccrzLCV667punwAfKmAR1qX3vJQbIEEsVtpGEBVF1WhH8TuYN+0E U3GWtkVUJv8fWI4XM6EW0qB7Odnd89aMRXTbU6eeweYfcP5TZsIJfngO1Tqj1lMR7E1i JtvRD8UL2zkyS0a+SFyv03DoCE1AvrTZc/jWfF3pSOOhkvacQw7Bw3tK9q5uwoNxHdkv pEjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7ff661fS2dQVegnTR7XloTW2OTrMbw9EeqtHO2E4yKA=; b=RUgZbcxOLPi8t+mWPVrNfYURqoUq0IcokVnbwv44lowFp5WiBa4K7rwlQLmHred3vJ xK8kVzUsV9dDF6FpYqKVha8tR8owJWUngeohNO3nOt1+eXR9eIfsJl0+fz8J7sxCXm37 PisqxjRSVw87lpJTVkWulG87HdREdDIDaqv+XXdLqjloFm8IzIxy2QO0570IL+u6K3DJ qL+grrka3QVSL/ykI/qjAgIBXwndCR1SoN9mAv95LkQEDtOmr0v30oe2+w9GQqJhyQm3 wnck52Me0eJqQpAfy53ZR2s+2CbGK1LBXzhnjLLUozRcxSTMZQ2wUmhvK6EoH0eNRSOU znBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k65si1038311pge.422.2019.07.18.16.59.20; Thu, 18 Jul 2019 16:59:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbfGRX6T (ORCPT + 99 others); Thu, 18 Jul 2019 19:58:19 -0400 Received: from inva020.nxp.com ([92.121.34.13]:54474 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfGRX6R (ORCPT ); Thu, 18 Jul 2019 19:58:17 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 420721A0244; Fri, 19 Jul 2019 01:58:12 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 34D141A0135; Fri, 19 Jul 2019 01:58:12 +0200 (CEST) Received: from lorenz.ea.freescale.net (lorenz.ea.freescale.net [10.171.71.5]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id CBF10205D1; Fri, 19 Jul 2019 01:58:11 +0200 (CEST) From: Iuliana Prodan To: Herbert Xu , Horia Geanta , Aymen Sghaier Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx Subject: [PATCH v2 00/14] crypto: caam - fixes for kernel v5.3 Date: Fri, 19 Jul 2019 02:57:42 +0300 Message-Id: <1563494276-3993-1-git-send-email-iuliana.prodan@nxp.com> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The series solves: - the failures found with fuzz testing; - resources clean-up on caampkc/caamrng exit path. The first 10 patches solve the issues found with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled. They modify the drivers to provide a valid error (and not the hardware error ID) to the user, via completion callbacks. They check key length, assoclen, authsize and input size to solve the fuzz tests that expect -EINVAL to be returned when these values are not valid. The next 4 patches check the algorithm registration for caampkc module and unregister it only if the registration was successful. Also, on caampkc/caamrng, the exit point function is executed only if the registration was successful to avoid double freeing of resources in case the initialization function failed. --- Changes since V1: - update commit description for ("crypto: caam - update IV only when crypto operation succeeds"). --- Horia Geantă (5): crypto: caam/qi - fix error handling in ERN handler crypto: caam - fix return code in completion callbacks crypto: caam - update IV only when crypto operation succeeds crypto: caam - keep both virtual and dma key addresses crypto: caam - fix DKP for certain key lengths Iuliana Prodan (9): crypto: caam - check key length crypto: caam - check authsize crypto: caam - check assoclen crypto: caam - check zero-length input crypto: caam - update rfc4106 sh desc to support zero length input crypto: caam - free resources in case caam_rng registration failed crypto: caam - execute module exit point only if necessary crypto: caam - unregister algorithm only if the registration succeeded crypto: caam - change return value in case CAAM has no MDHA drivers/crypto/caam/Makefile | 2 +- drivers/crypto/caam/caamalg.c | 226 ++++++++++++++++---------- drivers/crypto/caam/caamalg_desc.c | 46 ++++-- drivers/crypto/caam/caamalg_desc.h | 2 +- drivers/crypto/caam/caamalg_qi.c | 222 +++++++++++++++---------- drivers/crypto/caam/caamalg_qi2.c | 316 ++++++++++++++++++++++++------------ drivers/crypto/caam/caamhash.c | 113 ++++++++----- drivers/crypto/caam/caamhash_desc.c | 5 +- drivers/crypto/caam/caamhash_desc.h | 2 +- drivers/crypto/caam/caampkc.c | 80 ++++++--- drivers/crypto/caam/caamrng.c | 17 +- drivers/crypto/caam/common_if.c | 88 ++++++++++ drivers/crypto/caam/common_if.h | 19 +++ drivers/crypto/caam/desc_constr.h | 34 ++-- drivers/crypto/caam/error.c | 61 ++++--- drivers/crypto/caam/error.h | 2 +- drivers/crypto/caam/key_gen.c | 5 +- drivers/crypto/caam/qi.c | 10 +- drivers/crypto/caam/regs.h | 1 + 19 files changed, 851 insertions(+), 400 deletions(-) create mode 100644 drivers/crypto/caam/common_if.c create mode 100644 drivers/crypto/caam/common_if.h -- 2.1.0