Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3117736ybi; Thu, 18 Jul 2019 21:22:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNa6dNvyV+w0BQ4fRfq1BFKjmiuyBX7Q2LnVOD+ZeNED5hB96nxG8otCIxPelBGjM40YFB X-Received: by 2002:a63:4e58:: with SMTP id o24mr50743198pgl.366.1563510134309; Thu, 18 Jul 2019 21:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563510134; cv=none; d=google.com; s=arc-20160816; b=CB39Q4vk7U3iFRY0lm1LmM5pj/2PkeWlL7bsKSw+oBhbjVOAoOplM3u0FicYiYR91C ChCMihwyYlDiTxB/cS/SW9HcHBijG9iGUNLAco5iz4YchAVoNqPgptyM/5hr4M2SO3zU uUuTFoTX3kpCTGD1oJcEnjgGHLsQM8KIKQs582Q/iqwomtN+B2DuB1AcbV4j2PAOuaZZ 9x7DpEb71Qbinlzv9xNNSCB18tQsQgOJIW6WQSPNdd6oIX/IC0BXlcm4PDP19UzA3dNw 8ikY0vTuTwa8SILXSsu2oaC3j0HIt1mkYMCNSlw/+Awa7n56lNcEAORlDtM2XVitNhYb 7xKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CrLAZNmpd09n/JYZaoND2r+5QUXn9yyhf3HWOpF+6rA=; b=D1wyvREPMIfZ+BmZhjIIl14mGNp4TZQ97LA43PjFN8IPJRwSpoPEF6/QTp6ct7riLo 32EF2koeFXam4oHfZg0bnot/MaTh6vYKcsAlZM3zTS0fKE7S1A1eniUo68i8P8Mtg1F4 4HqqS/IzD0fLdys/QT7zuPRLWSodYeY+s/TTahKnFNgT+Z2e6vZThgso+y0Ly2zx1AkL VuFrruvR0k0OUPl+tHTnSIF8t2kA1pEzm1WV2I+P3mFyLopQKCV7ztJTiJ3RZs/Ou/hp q1FYMgF/k8gfMr7YMQcW8l+v1KnCIDyvppvrPRPzuuG3D4CEjYeO/GbJdjo/m5Xd/sFR MM2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PoAwjjCp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si554236pls.183.2019.07.18.21.21.59; Thu, 18 Jul 2019 21:22:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PoAwjjCp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732409AbfGSEVI (ORCPT + 99 others); Fri, 19 Jul 2019 00:21:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:47420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732862AbfGSEMK (ORCPT ); Fri, 19 Jul 2019 00:12:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DC7B21872; Fri, 19 Jul 2019 04:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509530; bh=NKN2kMwDMv/CtJoT/kNNSdoQYzqkb1OZN7iL5M3DnOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PoAwjjCp+Io96ivyMf/In1cpjbSBl9JM8biYDlVJXdv/AYQ2MkRQBh6mEI0j5MwLM 0WDWFyc6PMKXFYWr1Pqe+1xFX7lgcQGhsm7pH8ifspXuoWKTbHtJku4nVgN1R+3DEY xUrHI39+b9Rc0KlxzLGahiExdzyi2W4+cKtSW0NY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Robert Hancock , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.14 33/60] mfd: core: Set fwnode for created devices Date: Fri, 19 Jul 2019 00:10:42 -0400 Message-Id: <20190719041109.18262-33-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719041109.18262-1-sashal@kernel.org> References: <20190719041109.18262-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robert Hancock [ Upstream commit c176c6d7e932662668bcaec2d763657096589d85 ] The logic for setting the of_node on devices created by mfd did not set the fwnode pointer to match, which caused fwnode-based APIs to malfunction on these devices since the fwnode pointer was null. Fix this. Signed-off-by: Robert Hancock Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index c57e407020f1..5c8ed2150c8b 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -179,6 +179,7 @@ static int mfd_add_device(struct device *parent, int id, for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; + pdev->dev.fwnode = &np->fwnode; break; } } -- 2.20.1