Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [GIT PULL] Modules updates for v5.3
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Jessica Yu <jeyu@kernel.org>
Cc:     Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
References: <20190718113346.GA19574@linux-8ccs>
 <CAHk-=whjTFKB3TPPkgCvMX9P+C=hy2ZjhQy7C5reTQKV6MtuOw@mail.gmail.com>
From:   Prarit Bhargava <prarit@redhat.com>
Message-ID: <e6fec7b7-40de-884e-a37b-f60dcc129c02@redhat.com>
Date:   Fri, 19 Jul 2019 07:38:07 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <CAHk-=whjTFKB3TPPkgCvMX9P+C=hy2ZjhQy7C5reTQKV6MtuOw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/18/19 3:20 PM, Linus Torvalds wrote:
> On Thu, Jul 18, 2019 at 4:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>>
>> Modules updates for v5.3
>>
>> - Fix bug where -EEXIST was being returned for going modules
> 
> Hmm.
> 
> I have pulled this, but this change makes me a bit nervous.
> 
> I have this dim memory of us having deadlocks in module loading
> because module loading triggered other modules to be loaded, and we
> had circular dependencies..
> 

Interesting.  I'll try to search around to see if I can find the thread.

P.

> This is from years and years ago (that whole state check is not
> recent), so my memory may simply be wrong, but I thought I'd mention
> it...
> 
>                    Linus
>