Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3830685ybi; Fri, 19 Jul 2019 09:46:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmg6NlTaeda9CX1YlncUxbkKmY1ODOsAoxmAPN1omBZ8L2Ahd/GU5EBSaEa8612nNBKqst X-Received: by 2002:a17:902:c509:: with SMTP id o9mr58917573plx.222.1563554778894; Fri, 19 Jul 2019 09:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563554778; cv=none; d=google.com; s=arc-20160816; b=RYRBL9lf+ermYecA/wMDMYrJ+iZBS3A1FUInQzjXaO60SAy3a1YV9WktM2qfqYhYGF xPmVh/xmNl8BXVnjKIOfiCDAXAaUfHbgNS6Fxzob23Q6CGr5inv0kIswLUPwjtSbEWtg Br0yMkzSySodxyXuwJIyx3cGieDeCUow/GiI3bQ9qgE8aDsUUd/m/l7eSVNVNluAUvYg sWl8eXbu81FrJA6N8UPdDBqIulgP6Ad0n1okYEY2S+lkU686+PqMTg++Owr5Z9OPP+cL UBjsUl55k0OE69QZMwcXfLrEfWezQLw9+m+nLGEYYZ4fHSNfIJxTAFPj0eqJYiHbDScg fr6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=pCZ8DR2DQ083nJLI21sPkv5KRO9eoBXxdCtJuR2wEUE=; b=AuyUVVFtB87nhc+dX1/AHsEd2sT9kGGaPyp8fUAWlte9B+Hjq9KtyLhb56e+AUM/jy ai4W/jBaaVvNdyZUS9RyZ1HCnYauEiGFEeJ+XIy43UPXk+9CL40Pu25gTvYK1hg8SKb2 rTnnRCKjF4+WZlz2A0V+SqQQzsVGNJMI+zVXn5TD93dHVq88eCwt5u0KTn96Yee6kt9o ec+Q3+8rHtlRfReOjJQDcIC+tpEoVayeyAOIdkOfEPdpp/soZP8PfLZt14CCmTtVGrBp T2Bl0Chknxvah1TOl4CMV1Z8Vdcb72iZdE/k1Uv6MV32ziefMnktV3JpVP4moUrPEUHE LYaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si3145707pfo.138.2019.07.19.09.46.03; Fri, 19 Jul 2019 09:46:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728790AbfGSPXa (ORCPT + 99 others); Fri, 19 Jul 2019 11:23:30 -0400 Received: from gate.crashing.org ([63.228.1.57]:49471 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfGSPX3 (ORCPT ); Fri, 19 Jul 2019 11:23:29 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x6JFN5qY026512; Fri, 19 Jul 2019 10:23:05 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x6JFN4GP026509; Fri, 19 Jul 2019 10:23:04 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 19 Jul 2019 10:23:03 -0500 From: Segher Boessenkool To: Nathan Chancellor Cc: Christophe Leroy , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v2] powerpc: slightly improve cache helpers Message-ID: <20190719152303.GA20882@gate.crashing.org> References: <45hnfp6SlLz9sP0@ozlabs.org> <20190708191416.GA21442@archlinux-threadripper> <20190709064952.GA40851@archlinux-threadripper> <20190719032456.GA14108@archlinux-threadripper> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190719032456.GA14108@archlinux-threadripper> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 08:24:56PM -0700, Nathan Chancellor wrote: > On Mon, Jul 08, 2019 at 11:49:52PM -0700, Nathan Chancellor wrote: > > On Tue, Jul 09, 2019 at 07:04:43AM +0200, Christophe Leroy wrote: > > > Is that a Clang bug ? > > > > No idea, it happens with clang-8 and clang-9 though (pretty sure there > > were fixes for PowerPC in clang-8 so something before it probably won't > > work but I haven't tried). > > > > > > > > Do you have a disassembly of the code both with and without this patch in > > > order to compare ? > > > > I can give you whatever disassembly you want (or I can upload the raw > > files if that is easier). > > What disassembly/files did you need to start taking a look at this? I > can upload/send whatever you need. A before and after of *only this patch*. And then look at what changed; it maybe be obvious what is the problem to you, as well, so look at it yourself first? Segher