Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Jul 2019 18:53:46 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <CAJWu+orxkFyoTTmFJs23FD0PKX-NetF4kVVLXnWkyLdCU2_cYQ@mail.gmail.com>
References: <20190717172100.261204-1-joel@joelfernandes.org> <20190719161404.GA24170@redhat.com> <20190719162726.u5fi5k3tqove6hgn@brauner.io> <CAJWu+orxkFyoTTmFJs23FD0PKX-NetF4kVVLXnWkyLdCU2_cYQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH RFC v1] pidfd: fix a race in setting exit_state for pidfd polling
To:     Joel Fernandes <joelaf@google.com>
CC:     Oleg Nesterov <oleg@redhat.com>,
        "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        "Cc: Android Kernel" <kernel-team@android.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Tejun Heo <tj@kernel.org>
From:   Christian Brauner <christian@brauner.io>
Message-ID: <28DEE709-0BD6-4915-B9AB-0ACCC7C02111@brauner.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On July 19, 2019 6:51:20 PM GMT+02:00, Joel Fernandes <joelaf@google=2Ecom>=
 wrote:
>On Fri, Jul 19, 2019 at 12:27 PM Christian Brauner
><christian@brauner=2Eio> wrote:
>>
>> On Fri, Jul 19, 2019 at 06:14:05PM +0200, Oleg Nesterov wrote:
>> > it seems that I missed something else=2E=2E=2E
>> >
>> > On 07/17, Joel Fernandes (Google) wrote:
>> > >
>> > > @@ -1156,10 +1157,11 @@ static int wait_task_zombie(struct
>wait_opts *wo, struct task_struct *p)
>> > >             ptrace_unlink(p);
>> > >
>> > >             /* If parent wants a zombie, don't release it now */
>> > > -           state =3D EXIT_ZOMBIE;
>> > > +           p->exit_state =3D EXIT_ZOMBIE;
>> > >             if (do_notify_parent(p, p->exit_signal))
>> > > -                   state =3D EXIT_DEAD;
>> > > -           p->exit_state =3D state;
>> > > +                   p->exit_state =3D EXIT_DEAD;
>> > > +
>> > > +           state =3D p->exit_state;
>> > >             write_unlock_irq(&tasklist_lock);
>> >
>> > why do you think we also need to change wait_task_zombie() ?
>> >
>> > pidfd_poll() only needs the exit_state !=3D 0 check, we know that it
>> > is not zero at this point=2E Why do we need to change exit_state
>before
>> > do_notify_parent() ?
>>
>> Oh, because of?:
>>
>>         /*
>>          * Move the task's state to DEAD/TRACE, only one thread can
>do this=2E
>>          */
>>         state =3D (ptrace_reparented(p) && thread_group_leader(p)) ?
>>                 EXIT_TRACE : EXIT_DEAD;
>>         if (cmpxchg(&p->exit_state, EXIT_ZOMBIE, state) !=3D
>EXIT_ZOMBIE)
>>                 return 0;
>>
>> So exit_state will definitely be set in this scenario=2E Good point=2E
>>
>
>Agreed=2E Christian, do you mind dropping this hunk from the patch or do
>you want me to resend the patch with the hunk dropped?

Yeah, no problem=2E :)