Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Jul 2019 09:45:45 -0700
From:   Matthias Kaehlcke <mka@chromium.org>
To:     Adam Jackson <ajax@redhat.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Douglas Anderson <dianders@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the
 internal I2C controller
Message-ID: <20190719164545.GU250418@google.com>
References: <20190718214135.79445-1-mka@chromium.org>
 <617ef7670a35f0be6beba79ecdaba8be26154868.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <617ef7670a35f0be6beba79ecdaba8be26154868.camel@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 19, 2019 at 12:23:26PM -0400, Adam Jackson wrote:
> On Thu, 2019-07-18 at 14:41 -0700, Matthias Kaehlcke wrote:
> 
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > index 045b1b13fd0e..e49402ebd56f 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -35,6 +35,7 @@
> >  
> >  #include <media/cec-notifier.h>
> >  
> > +#define DDC_I2C_ADDR		0x37
> 
> This confused the heck out of me to read, DDC by definition happens
> over I2C and this one address is just for a specific subset of DDC.
> Perhaps this would be clearer if it was named DDC_CI_ADDR.

I was also a bit confused about the terminology, some places call 0x37
the DDC address and 0x50 the EDID address.

DDC_CI_ADDR sounds good to me, thanks for the suggestion!

I'll wait a day or two before respinning, for if there are more comments.