Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4707523ybi; Sat, 20 Jul 2019 04:32:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1gimjhurrqG3BqKc4tj22BAI5P1mp3wsjq5q2U0w3yZL5tkVh2uj7w7FhA/APv8AV0Ehh X-Received: by 2002:a17:90a:228b:: with SMTP id s11mr62141391pjc.23.1563622353490; Sat, 20 Jul 2019 04:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563622353; cv=none; d=google.com; s=arc-20160816; b=Jp+U+rMlcIouIvLaSZMTFe8XuoYLnUPf00GdUTjHfQmXedJvczENKXfPEbKmmcltiZ H20ub476O/dIPVDyX/HfhSknAOo+PDmyd1AGLhMkmcKuzEgsXE0ccD7ouXNKHmJeTvPa TLnl20EWK9AM/hLrwE0dJekxa4ijWK+jJ864hEVAIhPsbxdlGzQz52IK0PmLmOpSMB4H a7o3y1kUwSX5EvSmQH7tLRmK1nUJWmhe9zBt5Oxr9UmaGJbCu0ZT3cYTi2fDy35f4WS6 i4AdsEKHpBXDSC991kuwcbmFsdlTzf4ZOl/F604QFHMNAodkkgDaIrevRTM6RwRzZUjj x3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=TNz48T21phQLQ6OyebULqz3BMa7UYeuzbKMVgfEQGEo=; b=ef/7l9YUUmIRXuCFuzfc+yeNu7oPWcGZj26ut1wfwZHhHkFXmuKjCW557+4DIlHNtW chCHOuBULVsYzSqdIe8H/eCl7N6tH5OwTDvoTOILwaAk2mNTmCAH8exZaayJQrOTphMw mhyRvpFBYgm9ks/z8kvCdOveo20Yax+Ldw0d66Zef3UWxqEmq391RphC+8qyL8QM5Y/p 8MVXNkpYIGv6W+pj7a7BxgpUUFoNcm0mNmdEunvACeMbg3pLhgxStSPnv6kknCsshtlv 785begmIDDFlQ+xPdyjV2aCZGJD2tZp+UloJc3D79MradAzT3jvLvUQ8n9fnkXNcjT6v Ulmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x61si4150276plb.336.2019.07.20.04.31.47; Sat, 20 Jul 2019 04:32:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388715AbfGTAK2 (ORCPT + 99 others); Fri, 19 Jul 2019 20:10:28 -0400 Received: from mx1.mailbox.org ([80.241.60.212]:35184 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730015AbfGTAK2 (ORCPT ); Fri, 19 Jul 2019 20:10:28 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 503C9501CC; Sat, 20 Jul 2019 02:10:21 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id wYoKm814sQqS; Sat, 20 Jul 2019 02:10:12 +0200 (CEST) Date: Sat, 20 Jul 2019 10:09:30 +1000 From: Aleksa Sarai To: shuah Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Christian Brauner , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Aleksa Sarai , Linus Torvalds , containers@lists.linux-foundation.org, linux-alpha@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v10 8/9] kselftest: save-and-restore errno to allow for %m formatting Message-ID: <20190720000930.g3jyjupgimptuubl@yavin> References: <20190719164225.27083-1-cyphar@cyphar.com> <20190719164225.27083-9-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="636rtrosv3xeor7c" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --636rtrosv3xeor7c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-07-19, shuah wrote: > On 7/19/19 10:42 AM, Aleksa Sarai wrote: > > Previously, using "%m" in a ksft_* format string can result in strange > > output because the errno value wasn't saved before calling other libc > > functions. The solution is to simply save and restore the errno before > > we format the user-supplied format string. > >=20 > > Signed-off-by: Aleksa Sarai > [...] > Hi Aleksa, >=20 > Can you send this patch separate from the patch series. I will apply > this as bug fix to 5.3-rc2 or rc3. >=20 > This isn't part of this series anyway and I would like to get this in > right away. Done, and I'll drop it in v11 after the rest gets reviewed. --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --636rtrosv3xeor7c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXTJbtgAKCRCdlLljIbnQ ErjeAQDm5ltY062NGtOMR1eaop8IvTWe5GYu7R+vym5BewUWYgD9HGmujOKl8CQ5 rJXhxSxnaze1/BDj2gUmfSjSP3IJNwo= =CHUB -----END PGP SIGNATURE----- --636rtrosv3xeor7c--